Fix stale LB25 state causing spurious breaks after colon-separated text#523
Merged
JimBobSquarePants merged 3 commits intomainfrom Apr 7, 2026
Merged
Fix stale LB25 state causing spurious breaks after colon-separated text#523JimBobSquarePants merged 3 commits intomainfrom
JimBobSquarePants merged 3 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #523 +/- ##
=====================================
- Coverage 82% 82% -1%
=====================================
Files 305 305
Lines 21534 21540 +6
Branches 3165 3167 +2
=====================================
+ Hits 17818 17822 +4
- Misses 2901 2903 +2
Partials 815 815
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This pull request significantly improves the maintainability and clarity of the
LineBreakEnumeratorimplementation insrc/SixLabors.Fonts/Unicode/LineBreakEnumerator.csby adding detailed, specification-driven comments, refactoring for readability, and enhancing documentation. Additionally, it introduces a new unit test to cover a previously reported issue.Documentation and Maintainability Improvements:
LineBreakEnumeratorto closely align with the Unicode Line Breaking Algorithm (UAX 14), making rule references explicit and clarifying the purpose of internal state and logic. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19]Correctness and Algorithmic Clarifications:
Testing:
Issues_522) to verify that the line break enumerator does not break within an alphanumeric run following a colon, addressing a previously reported issue and improving test coverage.