Repository navigation
Fix disjunction split across pipeline boundary with deferred regex branch - #78
Merged
Merged
Conversation
…ferred regex (#74) Co-authored-by: thomaspatzke <1845601+thomaspatzke@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix deferred expressions split across pipeline boundary
Fix disjunction split across pipeline boundary with deferred regex branch
Sep 19, 2026
thomaspatzke
approved these changes
Sep 20, 2026
thomaspatzke
marked this pull request as ready for review
September 20, 2026 08:32
thomaspatzke
deleted the
copilot/fix-deferred-expressions-disjunction
branch
September 20, 2026 08:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a rule condition is a top-level disjunction and one branch contains a
|remodifier, the deferredrex/evalhoisting logic infinalize_query_defaultincorrectly extracted the first disjunct as a prefix, leaving| search OR ...— invalid SPL that also silently inverts the logic from OR to AND.Root cause:
finalize_query_defaultgreedily matched leadingfield=valuetokens to hoist before the deferred pipeline stages, without checking whether the remaining suffix began withOR(i.e., whether it was splitting a disjunction).Fix (
sigma/backends/splunk/splunk.py):remaining_query.lstrip().startswith("OR")— keeps the full disjunction intact in the trailing| searchclause.Test (
tests/test_backend_splunk.py):A or (B and not <regex-filter>)shape, asserting\n| search ORnever appears and both disjuncts are present in the final search stage.Before:
After: