Skip to content

fix(ci): restore green lint/tests after recent merges - #359

Merged
ShreeChaturvedi merged 1 commit into
mainfrom
fix/ci-lint-errors
Aug 3, 2026
Merged

ShreeChaturvedi merged 1 commit into
mainfrom
fix/ci-lint-errors

Conversation

@ShreeChaturvedi

Copy link
Copy Markdown
Owner

Summary

Default-branch CI failed at Lint after several merged fix PRs. This restores a green main with real fixes only.

Fixes

  • tuningService.ts: misplaced buildNJobsPythonSnippet import (parse error at L30)
  • auth/middleware tests: replace any with typed mocks / vi.hoisted
  • import/order: eslint --fix across backend
  • api client: call notifyApiActivity() on successful apiFetch (unused fn was lint error; was intended by fix(auth): session expiry warning only after true idle #357)
  • deploymentStore: reconcile after failed create without wiping optimistic row or clearing error via refreshDeployments

Local verification

npm run lint && npm run build && npm run test — exit 0
(backend 1317 tests, frontend 970 tests)

- Repair broken import splice in tuningService (n_jobs PR)
- Remove no-explicit-any from auth/middleware unit tests
- Wire notifyApiActivity on successful apiFetch (session idle)
- Fix failed-deploy optimistic row reconcile without clearing error
- Auto-fix import/order warnings so eslint exits clean
@ShreeChaturvedi
ShreeChaturvedi merged commit 9797c23 into main Aug 3, 2026
2 checks passed
@ShreeChaturvedi
ShreeChaturvedi deleted the fix/ci-lint-errors branch August 3, 2026 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant