Build, test and lint on push

[SDL-A1]

Until now nothing did. .github/workflows held one file and it only ran cargo-deny, so every PR's test evidence was a human pasting local output, and a linter had never run at all.

Closes #282.

What that cost

All found within an hour of installing clippy for the first time:

• test_rsk_message_rlp_transactions had no #[test] attribute and had never run (Clear the clippy backlog, and what it was hiding #281)
• #[test] applied twice to another test; #[cfg(test)] twice on a module
• 189 clippy warnings across 153 sites, including a real bug: tip.max(N).min(N) is always the constant, so scan_addr computed a tip and discarded it (Fix what clippy's deny-level lints found, and the warnings that meant something #279)
• three doc comments damaged by pasted section headers, one truncated mid-sentence (Three doc comments were damaged by pasted section headers; the lost text needs an author #283)
• 296 files drifted from rustfmt

Why the matrix builds two configurations

Not symmetry for its own sake. cargo clippy --fix removed a mut that only the smtp build needs — the sinks.push it guards sits behind #[cfg(feature = "smtp")]. A default build compiled and all 2,046 tests passed, while --features smtp would not compile at all.

That is the configuration the production node runs. A single-configuration gate would have shipped it.

Jobs

job	what it runs	gating
test	cargo build --locked + cargo test --locked, matrix {default: --workspace} and {smtp: -p rustock-cli --features smtp}	yes
clippy	--workspace --all-targets -- -D warnings, plus the same for --features smtp	yes
fmt	cargo fmt --all --check, reporting how many files differ	advisory (continue-on-error)

--all-targets because the one genuine bug clippy found was in an example, which a bare cargo clippy does not lint.

RUSTFLAGS: -D warnings globally, because most of the real findings were plain rustc warnings — an unused import, an unreachable statement — rather than clippy lints.

Why fmt is advisory

296 files differ. Formatting them is a deliberate commit of its own; folding it in would bury any change in ~1,800 lines of churn. Reporting the count keeps it visible and shrinking rather than silently growing. Flip continue-on-error off once that commit lands.

Expected first run

The gate passes on main as of #281:

cargo clippy --workspace --all-targets -- -D warnings   exit 0
cargo test --workspace                                  2,046 passed
cargo test -p rustock-cli --features smtp                  27 passed

The fmt job will report ~296 files and stay green by design.

Note: the existing cargo-deny job logs override toolchain '1.93.1-x86_64-unknown-linux-musl' is not installed, so rust-toolchain.toml is not honoured there. This workflow pins the toolchain explicitly instead.

🤖 Generated with Claude Code