Fix AbstractProcessingHandler::handle() to call getBubble() instead of $this->bubble#2031
Open
philbates35 wants to merge 1 commit into
Open
Conversation
…f reading \$bubble directly Subclasses that override getBubble() to dynamically control bubbling behaviour were bypassed because handle() read the protected \$bubble property directly. Switching to !$this->getBubble() ensures the getter is always respected. Regression test added to AbstractProcessingHandlerTest. Relates to symfony/symfony#64207 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
philbates35
changed the title
GromNaN
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AbstractProcessingHandler::handle()was reading the protected$bubbleproperty directly (false === $this->bubble) rather than callinggetBubble()getBubble()to dynamically control bubbling behaviour are silently bypassed!$this->getBubble()so the getter is always honouredContext
This was discovered while working on a Symfony MonologBridge fix where a handler needed to override
getBubble()to conditionally suppress propagation based on runtime state. The Symfony maintainers suggested the fix belongs upstream in Monolog: symfony/symfony#64207