-
Notifications
You must be signed in to change notification settings - Fork 1.7k
desktop-plus: Add version 3.6.2.1 #18276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
scillidan
wants to merge
4
commits into
ScoopInstaller:master
Choose a base branch
from
scillidan:desktop-plus
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+47
−0
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| { | ||
| "version": "3.6.4.2", | ||
| "description": "A GitHub Desktop fork with advanced functionality and improvements.", | ||
| "homepage": "https://desktop-plus.org", | ||
| "license": "MIT", | ||
| "notes": [ | ||
| "Desktop Plus includes a CLI that lets you open repositories and clone them directly from the terminal.", | ||
| "You can try `desktop-plus-cli --help`.", | ||
| "See more on https://github.com/desktop-plus/desktop-plus/blob/main/docs/cli.md" | ||
| ], | ||
| "architecture": { | ||
| "64bit": { | ||
| "url": "https://github.com/desktop-plus/desktop-plus/releases/download/v3.6.4.2/DesktopPlus-v3.6.4.2-windows-x64.exe#/DesktopPlus.exe", | ||
| "hash": "bc5fa422fdd99ead0581c6009105d19f8ecb7c0330ca76fbbd2272c80ec371a8" | ||
| }, | ||
| "arm64": { | ||
| "url": "https://github.com/desktop-plus/desktop-plus/releases/download/v3.6.4.2/DesktopPlus-v3.6.4.2-windows-arm64.exe#/DesktopPlus.exe", | ||
| "hash": "f914123816c81bc458d2e48a7e9f266ec9f44447f48d24fe5f442c39684ca39b" | ||
| } | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| }, | ||
| "post_install": [ | ||
| "$batPath = \"$env:LOCALAPPDATA\\DesktopPlus\\bin\\desktop-plus-cli.bat\"", | ||
| "if (Test-Path $batPath) {", | ||
| " shim $batPath $global 'desktop-plus-cli'", | ||
| "}" | ||
| ], | ||
| "shortcuts": [ | ||
| [ | ||
| "DesktopPlus.exe", | ||
| "Desktop Plus" | ||
| ] | ||
| ], | ||
| "post_uninstall": "rm_shim 'desktop-plus-cli' \"$(shimdir $global)\"", | ||
| "checkver": { | ||
| "github": "https://github.com/desktop-plus/desktop-plus" | ||
| }, | ||
| "autoupdate": { | ||
| "architecture": { | ||
| "64bit": { | ||
| "url": "https://github.com/desktop-plus/desktop-plus/releases/download/v$version/DesktopPlus-v$version-windows-x64.exe#/DesktopPlus.exe" | ||
| }, | ||
| "arm64": { | ||
| "url": "https://github.com/desktop-plus/desktop-plus/releases/download/v$version/DesktopPlus-v$version-windows-arm64.exe#/DesktopPlus.exe" | ||
| } | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟠 Major
Use a portable asset or model the Windows installer explicitly.
Lines 13 and 17 download Windows setup executables. Upstream creates these files through
electron-winstaller.createWindowsInstaller()and assigns them assetupExefiles. The release page lists the samewindows-x64.exeandwindows-arm64.exeassets. (raw.githubusercontent.com)The
#/DesktopPlus.exefragment only renames the download. It does not make the setup executable portable. Without aninstallerflow, the shortcut at Lines 29-30 targets the setup program, and the CLI hook cannot rely on the%LOCALAPPDATA%CLI file being created. Use a genuine portable asset, or add a complete installer/uninstaller flow and target the installed application binary. See the official Scoop manifest guidance for URL fragments and installer hooks. (github.com)As per path instructions, use the official Scoop manifest guidance when correcting this manifest.
🤖 Prompt for AI Agents
Sources: Path instructions, MCP tools