Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions bucket/desktop-plus.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
{
"version": "3.6.4.2",
"description": "A GitHub Desktop fork with advanced functionality and improvements.",
"homepage": "https://desktop-plus.org",
"license": "MIT",
"notes": [
"Desktop Plus includes a CLI that lets you open repositories and clone them directly from the terminal.",
"You can try `desktop-plus-cli --help`.",
"See more on https://github.com/desktop-plus/desktop-plus/blob/main/docs/cli.md"
],
"architecture": {
"64bit": {
"url": "https://github.com/desktop-plus/desktop-plus/releases/download/v3.6.4.2/DesktopPlus-v3.6.4.2-windows-x64.exe#/DesktopPlus.exe",
"hash": "bc5fa422fdd99ead0581c6009105d19f8ecb7c0330ca76fbbd2272c80ec371a8"
},
"arm64": {
"url": "https://github.com/desktop-plus/desktop-plus/releases/download/v3.6.4.2/DesktopPlus-v3.6.4.2-windows-arm64.exe#/DesktopPlus.exe",
"hash": "f914123816c81bc458d2e48a7e9f266ec9f44447f48d24fe5f442c39684ca39b"
Comment on lines +13 to +18

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟠 Major

Use a portable asset or model the Windows installer explicitly.

Lines 13 and 17 download Windows setup executables. Upstream creates these files through electron-winstaller.createWindowsInstaller() and assigns them as setupExe files. The release page lists the same windows-x64.exe and windows-arm64.exe assets. (raw.githubusercontent.com)

The #/DesktopPlus.exe fragment only renames the download. It does not make the setup executable portable. Without an installer flow, the shortcut at Lines 29-30 targets the setup program, and the CLI hook cannot rely on the %LOCALAPPDATA% CLI file being created. Use a genuine portable asset, or add a complete installer/uninstaller flow and target the installed application binary. See the official Scoop manifest guidance for URL fragments and installer hooks. (github.com)

As per path instructions, use the official Scoop manifest guidance when correcting this manifest.

#!/usr/bin/env bash
set -euo pipefail

release='https://github.com/desktop-plus/desktop-plus/releases/expanded_assets/v3.6.4.2'
package='https://raw.githubusercontent.com/desktop-plus/desktop-plus/main/script/package.ts'
dist_info='https://raw.githubusercontent.com/desktop-plus/desktop-plus/main/script/dist-info.ts'

curl -fsSL "$release" | grep -E 'DesktopPlus-v3\.6\.4\.2-windows-(x64|arm64)\.exe'
curl -fsSL "$package" | grep -nE 'createWindowsInstaller|setupExe'
curl -fsSL "$dist_info" | grep -nE 'getWindowsStandaloneName|windows-\$\{getDistArchitecture\}'
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@bucket/desktop-plus.json` around lines 13 - 18, Update the x64 and arm64
entries in the manifest to use a genuine portable asset, or explicitly model the
Windows installer with the required installer/uninstaller flow and target the
installed application binary for shortcuts and CLI hooks. Follow official Scoop
manifest guidance for URL fragments and installer hooks, and preserve
architecture-specific URLs and hashes.

Sources: Path instructions, MCP tools

}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
},
"post_install": [
"$batPath = \"$env:LOCALAPPDATA\\DesktopPlus\\bin\\desktop-plus-cli.bat\"",
"if (Test-Path $batPath) {",
" shim $batPath $global 'desktop-plus-cli'",
"}"
],
"shortcuts": [
[
"DesktopPlus.exe",
"Desktop Plus"
]
],
"post_uninstall": "rm_shim 'desktop-plus-cli' \"$(shimdir $global)\"",
"checkver": {
"github": "https://github.com/desktop-plus/desktop-plus"
},
"autoupdate": {
"architecture": {
"64bit": {
"url": "https://github.com/desktop-plus/desktop-plus/releases/download/v$version/DesktopPlus-v$version-windows-x64.exe#/DesktopPlus.exe"
},
"arm64": {
"url": "https://github.com/desktop-plus/desktop-plus/releases/download/v$version/DesktopPlus-v$version-windows-arm64.exe#/DesktopPlus.exe"
}
}
}
}
Loading