Skip to content

[compiler] Add support for Python 3.13 #16445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arkq wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[compiler] Add support for Python 3.13 #16445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions compiler/common-artifacts/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#[[ Generate common python virtual enviornment ]]
#[[ Generate common python virtual environment ]]
# NOTE find_package try to use at least python3.10 as follows depending on platform version
# Ubuntu20.04; explictly installed python3.10 (default is python3.8)
# Ubuntu20.04; explicitly installed python3.10 (default is python3.8)
# Ubuntu22.04; default python3.10
# Ubuntu24.04; default python3.12
# refer https://github.com/Samsung/ONE/issues/9962
Expand All @@ -16,11 +16,13 @@ if(NOT Python_Interpreter_FOUND)
return()
endif()

# NOTE assume only use 3.10.x or 3.12.x
# NOTE assume only use 3.10.x, 3.12.x or 3.13.x
if((Python_VERSION VERSION_GREATER_EQUAL 3.10) AND (Python_VERSION VERSION_LESS 3.11))
set(PYTHON_VERSION_MINOR 10)
elseif((Python_VERSION VERSION_GREATER_EQUAL 3.12) AND (Python_VERSION VERSION_LESS 3.13))
set(PYTHON_VERSION_MINOR 12)
elseif((Python_VERSION VERSION_GREATER_EQUAL 3.13) AND (Python_VERSION VERSION_LESS 3.14))
set(PYTHON_VERSION_MINOR 13)
else()
# TODO support more
message(STATUS "Build common-artifacts: FAILED (Unsupported python: ${Python_VERSION})")
Expand Down Expand Up @@ -89,6 +91,21 @@ elseif (PYTHON_VERSION_MINOR EQUAL 12)
list(APPEND PY_PKG_LIST "h5py==3.11.0")
list(APPEND PY_PKG_LIST "cffi==1.16.0")
list(APPEND PY_PKG_LIST "numpy==1.26.4")
elseif (PYTHON_VERSION_MINOR EQUAL 13)
# python 3.13; Ubuntu 25.04
# TF2.20.0 release at 2025-08-19
if(CMAKE_HOST_SYSTEM_PROCESSOR STREQUAL "aarch64")
list(APPEND PY_PKG_LIST "tensorflow==2.20.0")
else(CMAKE_HOST_SYSTEM_PROCESSOR STREQUAL "aarch64")
list(APPEND PY_PKG_LIST "tensorflow-cpu==2.20.0")
endif(CMAKE_HOST_SYSTEM_PROCESSOR STREQUAL "aarch64")
list(APPEND PY_PKG_LIST "flatbuffers==24.3.25")
list(APPEND PY_PKG_LIST "protobuf==5.29.4")
list(APPEND PY_PKG_LIST "pydot==1.4.2")
list(APPEND PY_PKG_LIST "pytest==7.4.3")
list(APPEND PY_PKG_LIST "h5py==3.12.1")
list(APPEND PY_PKG_LIST "cffi==1.17.1")
list(APPEND PY_PKG_LIST "numpy==2.2.4")
else()
# should not enter here
message(FATAL_ERROR "Build common-artifacts: FAILED (Invalid python version)")
Expand Down
6 changes: 4 additions & 2 deletions compiler/dalgona/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# NOTE find_package will try to use at least python3.10 as follows depending on platform version
# Ubuntu20.04; explictly installed python3.10 (default is python3.8)
# Ubuntu20.04; explicitly installed python3.10 (default is python3.8)
# Ubuntu22.04; default python3.10
# Ubuntu24.04; default python3.12
# refer https://github.com/Samsung/ONE/issues/9962
Expand All @@ -16,11 +16,13 @@ if(NOT Python_Development_FOUND)
return()
endif()

# NOTE assume only use 3.10.x or 3.12.x
# NOTE assume only use 3.10.x, 3.12.x or 3.13.x
if((Python_VERSION VERSION_GREATER_EQUAL 3.10) AND (Python_VERSION VERSION_LESS 3.11))
set(PYTHON_VERSION_MINOR 10)
elseif((Python_VERSION VERSION_GREATER_EQUAL 3.12) AND (Python_VERSION VERSION_LESS 3.13))
set(PYTHON_VERSION_MINOR 12)
elseif((Python_VERSION VERSION_GREATER_EQUAL 3.13) AND (Python_VERSION VERSION_LESS 3.14))
set(PYTHON_VERSION_MINOR 13)
else()
# TODO support more
message(STATUS "Build dalgona: FAILED (Unsupported python: ${Python_VERSION})")
Expand Down
8 changes: 5 additions & 3 deletions compiler/one-cmds/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# NOTE find_package will try to use at least python3.10 as follows depending on platform version
# Ubuntu20.04; explictly installed python3.10 (default is python3.8)
# Ubuntu20.04; explicitly installed python3.10 (default is python3.8)
# Ubuntu22.04; default python3.10
# Ubuntu24.04; explicitly installed python3.8 (default is python3.12)
# refer https://github.com/Samsung/ONE/issues/9962
Expand All @@ -14,12 +14,14 @@ if(NOT Python_Interpreter_FOUND)
return()
endif()

# NOTE assume only use 3.10.x or 3.12.x
# NOTE PYTHON_VERSION_MINOR is not used but added for consistancy with common-artifacts and dalgona
# NOTE assume only use 3.10.x, 3.12.x or 3.13.x
# NOTE PYTHON_VERSION_MINOR is not used but added for consistency with common-artifacts and dalgona
if((Python_VERSION VERSION_GREATER_EQUAL 3.10) AND (Python_VERSION VERSION_LESS 3.11))
set(PYTHON_VERSION_MINOR 10)
elseif((Python_VERSION VERSION_GREATER_EQUAL 3.12) AND (Python_VERSION VERSION_LESS 3.13))
set(PYTHON_VERSION_MINOR 12)
elseif((Python_VERSION VERSION_GREATER_EQUAL 3.13) AND (Python_VERSION VERSION_LESS 3.14))
set(PYTHON_VERSION_MINOR 13)
else()
# TODO support more
message(STATUS "Build one-cmds: FAILED (Unsupported python: ${Python_VERSION})")
Expand Down
9 changes: 6 additions & 3 deletions compiler/one-cmds/one-prepare-venv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
# use +e as python3.10 may not exist in the system and 'command' will return error.
set +e

PYTHON_CANDIDATES=("python3.12" "python3.10" "python3")
PYTHON_CANDIDATES=("python3.13" "python3.12" "python3.10" "python3")
for py in "${PYTHON_CANDIDATES[@]}"; do
PYTHON3_EXEC=$(command -v "$py")
if [[ -n "${PYTHON3_EXEC}" ]]; then
Expand Down Expand Up @@ -70,9 +70,12 @@ VER_TICO="0.1.0"
PYTHON_VER=$(${VENV_PYTHON} -c "import sys; print(f'{sys.version_info.major}.{sys.version_info.minor}')" )
echo "Setting package version for python $PYTHON_VER"
if [[ "$PYTHON_VER" == "3.10" ]]; then
: # TODO change vesions
: # TODO change versions
elif [[ "$PYTHON_VER" == "3.12" ]]; then
: # TODO change vesions
: # TODO change versions
elif [[ "$PYTHON_VER" == "3.13" ]]; then
VER_TENSORFLOW=2.20.0
VER_NUMPY="2.2.4"
else
echo "Error one-prepare-venv: Unsupported python $PYTHON_VER"
exit 1
Expand Down
Loading