Skip to content

[onert] Remove layer_idx from op_attention #16279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glistening merged 2 commits into from
Nov 13, 2025
Merged

[onert] Remove layer_idx from op_attention #16279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b4d848
[onert] Remove layer_idx from op_attention
glistening Nov 11, 2025
45f5cef
Remove Param struct and repeated public:
glistening Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions runtime/onert/core/include/ir/operation/Attention.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,24 +41,10 @@ class Attention : public Operation
POS = 10,
};

struct Param
{
int layer_idx;
};

public:
Attention(const OperandIndexSequence &inputs, const OperandIndexSequence &outputs,
const Param &param);
Attention(const OperandIndexSequence &inputs, const OperandIndexSequence &outputs);

public:
void accept(OperationVisitor &v) const override;
OpCode opcode() const final { return OpCode::Attention; }

public:
const Param &param() const { return _param; }

private:
Param _param;
};

} // namespace onert::ir::operation
Expand Down
5 changes: 2 additions & 3 deletions runtime/onert/core/src/ir/operation/Attention.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@ namespace onert::ir::operation

void Attention::accept(OperationVisitor &v) const { v.visit(*this); }

Attention::Attention(const OperandIndexSequence &inputs, const OperandIndexSequence &outputs,
const Param &param)
: Operation{OperandConstraint::createExact(11u), inputs, outputs}, _param{param}
Attention::Attention(const OperandIndexSequence &inputs, const OperandIndexSequence &outputs)
: Operation{OperandConstraint::createExact(11u), inputs, outputs}
{
}

Expand Down
2 changes: 1 addition & 1 deletion runtime/onert/core/src/loader/CircleLoader.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ void CircleLoader::loadAttention(const Operator *op, ir::Graph &subg)

loadOperationIO(op, inputs, outputs);

std::unique_ptr<ir::Operation> new_op(new ir::operation::Attention(inputs, outputs, {}));
std::unique_ptr<ir::Operation> new_op(new ir::operation::Attention(inputs, outputs));
subg.addOperation(std::move(new_op));
}

Expand Down