Skip to content

[common-artifacts] Split python package list #15319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanshpark merged 1 commit into from
May 8, 2025
Merged

[common-artifacts] Split python package list #15319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 33 additions & 12 deletions compiler/common-artifacts/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,19 +71,40 @@ if(DEFINED ENV{ONE_PIP_OPTION_TRUST_HOST})
set(PIP_OPTION_TRUSTED_HOST --trusted-host pypi.python.org --trusted-host files.pythonhosted.org --trusted-host pypi.org)
endif()

# NOTE `tensorflow-cpu` package is not available for aarch64, so we use `tensorflow` package.
# NOTE refer https://github.com/Samsung/ONE/issues/15226 for versions
set(PY_PKG_LIST )
if(CMAKE_HOST_SYSTEM_PROCESSOR STREQUAL "aarch64")
# NOTE `tensorflow-cpu` package is not available for aarch64, so we use `tensorflow` package.
list(APPEND PY_PKG_LIST "tensorflow==2.12.1")
else(CMAKE_HOST_SYSTEM_PROCESSOR STREQUAL "aarch64")
list(APPEND PY_PKG_LIST "tensorflow-cpu==2.12.1")
endif(CMAKE_HOST_SYSTEM_PROCESSOR STREQUAL "aarch64")
list(APPEND PY_PKG_LIST "flatbuffers==23.5.26")
list(APPEND PY_PKG_LIST "protobuf==4.23.3")
list(APPEND PY_PKG_LIST "pydot==1.4.2")
list(APPEND PY_PKG_LIST "pytest==7.4.3")
list(APPEND PY_PKG_LIST "h5py==3.11.0")
list(APPEND PY_PKG_LIST "cffi==1.16.0")
if (PYTHON_VERSION_MINOR EQUAL 8)
# python3.8; Ubuntu 18.04, 20.04
if(CMAKE_HOST_SYSTEM_PROCESSOR STREQUAL "aarch64")
list(APPEND PY_PKG_LIST "tensorflow==2.12.1")
else(CMAKE_HOST_SYSTEM_PROCESSOR STREQUAL "aarch64")
list(APPEND PY_PKG_LIST "tensorflow-cpu==2.12.1")
endif(CMAKE_HOST_SYSTEM_PROCESSOR STREQUAL "aarch64")
list(APPEND PY_PKG_LIST "flatbuffers==23.5.26")
list(APPEND PY_PKG_LIST "protobuf==4.23.3")
list(APPEND PY_PKG_LIST "pydot==1.4.2")
list(APPEND PY_PKG_LIST "pytest==7.4.3")
list(APPEND PY_PKG_LIST "h5py==3.11.0")
list(APPEND PY_PKG_LIST "cffi==1.16.0")
elseif (PYTHON_VERSION_MINOR EQUAL 10)
# python 3.10; Ubuntu 22.04
if(CMAKE_HOST_SYSTEM_PROCESSOR STREQUAL "aarch64")
list(APPEND PY_PKG_LIST "tensorflow==2.12.1")
else(CMAKE_HOST_SYSTEM_PROCESSOR STREQUAL "aarch64")
list(APPEND PY_PKG_LIST "tensorflow-cpu==2.12.1")
endif(CMAKE_HOST_SYSTEM_PROCESSOR STREQUAL "aarch64")
list(APPEND PY_PKG_LIST "flatbuffers==23.5.26")
list(APPEND PY_PKG_LIST "protobuf==4.23.3")
list(APPEND PY_PKG_LIST "pydot==1.4.2")
list(APPEND PY_PKG_LIST "pytest==7.4.3")
list(APPEND PY_PKG_LIST "h5py==3.11.0")
list(APPEND PY_PKG_LIST "cffi==1.16.0")
Comment on lines +77 to +102
Copy link
Copy Markdown
Contributor

@shs-park shs-park May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that all the versions between Python 3.8 and 3.10 are currently the same.
Was this intentional?

Copy link
Copy Markdown
Contributor Author

@seanshpark seanshpark May 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this PR is splitting for supporting two versions.
upcoming PRs will do modifications and add 12 and so on.

else()
# TODO add for 12
# should not enter here
message(FATAL_ERROR "Build common-artifacts: FAILED (Invalid pyhon version)")
endif()

add_custom_command(
OUTPUT REQUIREMENTS_OVERLAY_PATH_clean
Expand Down