Skip to content

[plier-tf] Do not use local variable #15246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanshpark merged 1 commit into from
Apr 28, 2025
Merged

[plier-tf] Do not use local variable #15246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 16 additions & 24 deletions compiler/plier-tf/src/Convert.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,68 +44,60 @@ tensorflow::DataType get_datatype_attr(const tensorflow::NodeDef &node,
const std::string &attr_name)
{
assert(has_attr(node, attr_name));
const auto &attr = node.attr().at(attr_name);
assert(attr.value_case() == tensorflow::AttrValue::kType);
return attr.type();
assert(node.attr().at(attr_name).value_case() == tensorflow::AttrValue::kType);
return node.attr().at(attr_name).type();
}

const tensorflow::TensorShapeProto &get_shape_attr(const tensorflow::NodeDef &node,
const std::string &attr_name)
{
assert(has_attr(node, attr_name));
const auto &attr = node.attr().at(attr_name);
assert(attr.value_case() == tensorflow::AttrValue::kShape);
return attr.shape();
assert(node.attr().at(attr_name).value_case() == tensorflow::AttrValue::kShape);
return node.attr().at(attr_name).shape();
}

const tensorflow::TensorProto &get_tensor_attr(const tensorflow::NodeDef &node,
const std::string &attr_name)
{
assert(has_attr(node, attr_name));
const auto &attr = node.attr().at(attr_name);
assert(attr.value_case() == tensorflow::AttrValue::kTensor);
return attr.tensor();
assert(node.attr().at(attr_name).value_case() == tensorflow::AttrValue::kTensor);
return node.attr().at(attr_name).tensor();
}

const ::tensorflow::AttrValue_ListValue &get_list_attr(const tensorflow::NodeDef &node,
const std::string &attr_name)
{
assert(has_attr(node, attr_name));
const auto &attr = node.attr().at(attr_name);
assert(attr.value_case() == tensorflow::AttrValue::kList);
return attr.list();
assert(node.attr().at(attr_name).value_case() == tensorflow::AttrValue::kList);
return node.attr().at(attr_name).list();
}

const std::string &get_string_attr(const tensorflow::NodeDef &node, const std::string &attr_name)
{
assert(has_attr(node, attr_name));
const auto &attr = node.attr().at(attr_name);
assert(attr.value_case() == tensorflow::AttrValue::kS);
return attr.s();
assert(node.attr().at(attr_name).value_case() == tensorflow::AttrValue::kS);
return node.attr().at(attr_name).s();
}

int64_t get_int_attr(const tensorflow::NodeDef &node, const std::string &attr_name)
{
assert(has_attr(node, attr_name));
const auto &attr = node.attr().at(attr_name);
assert(attr.value_case() == tensorflow::AttrValue::kI);
return attr.i();
assert(node.attr().at(attr_name).value_case() == tensorflow::AttrValue::kI);
return node.attr().at(attr_name).i();
}

float get_float_attr(const tensorflow::NodeDef &node, const std::string &attr_name)
{
assert(has_attr(node, attr_name));
const auto &attr = node.attr().at(attr_name);
assert(attr.value_case() == tensorflow::AttrValue::kF);
return attr.f();
assert(node.attr().at(attr_name).value_case() == tensorflow::AttrValue::kF);
return node.attr().at(attr_name).f();
}

bool get_bool_attr(const tensorflow::NodeDef &node, const std::string &attr_name)
{
assert(has_attr(node, attr_name));
const auto &attr = node.attr().at(attr_name);
assert(attr.value_case() == tensorflow::AttrValue::kB);
return attr.b();
assert(node.attr().at(attr_name).value_case() == tensorflow::AttrValue::kB);
return node.attr().at(attr_name).b();
}

std::vector<int64_t> as_int64_list(const tensorflow::AttrValue_ListValue &lv)
Expand Down