[tools/onnx-subgraph] add config file parser for target device#15080
Merged
seanshpark merged 2 commits intoSamsung:masterfrom Apr 9, 2025
Merged
[tools/onnx-subgraph] add config file parser for target device#15080seanshpark merged 2 commits intoSamsung:masterfrom
seanshpark merged 2 commits intoSamsung:masterfrom
Conversation
add config file parser for target device with json ONE-DCO-1.0-Signed-off-by: Youxin Chen <yx113.chen@samsung.com>
seanshpark
reviewed
Apr 8, 2025
Comment on lines
+26
to
+27
| #include "graph.h" | ||
| enum class DeviceType |
Contributor
There was a problem hiding this comment.
Suggested change
| #include "graph.h" | |
| enum class DeviceType | |
| #include "graph.h" | |
| enum class DeviceType |
seanshpark
reviewed
Apr 8, 2025
tools/onnx_subgraph/include/device.h
Outdated
| class Device | ||
| { | ||
| private: | ||
| std::string onnxFile; |
Contributor
There was a problem hiding this comment.
Suggested change
| std::string onnxFile; | |
| std::string _onnxFile; |
seanshpark
reviewed
Apr 8, 2025
tools/onnx_subgraph/include/device.h
Outdated
Comment on lines
+46
to
+49
| std::vector<std::string> NPUPreferOp; | ||
| std::vector<std::string> CPUSupportOp; | ||
| std::vector<std::string> NPUSupportOp; | ||
| float max_subgraph_size; |
Contributor
There was a problem hiding this comment.
Suggested change
| std::vector<std::string> NPUPreferOp; | |
| std::vector<std::string> CPUSupportOp; | |
| std::vector<std::string> NPUSupportOp; | |
| float max_subgraph_size; | |
| std::vector<std::string> _NPUPreferOp; | |
| std::vector<std::string> _CPUSupportOp; | |
| std::vector<std::string> _NPUSupportOp; | |
| float _max_subgraph_size; |
seanshpark
reviewed
Apr 8, 2025
tools/onnx_subgraph/include/device.h
Outdated
| std::string getOnnxFile() { return onnxFile; } | ||
| }; | ||
|
|
||
| #endif |
Contributor
There was a problem hiding this comment.
Suggested change
| #endif | |
| #endif // DEVICE_H |
seanshpark
reviewed
Apr 8, 2025
| */ | ||
| #include "device.h" | ||
|
|
||
| void Device::GetDeviceJson(std::string json_path) { return; } |
Contributor
There was a problem hiding this comment.
Suggested change
| void Device::GetDeviceJson(std::string json_path) { return; } | |
| void Device::GetDeviceJson(const std::string &json_path) { return; } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related issue: #14534
historical full changes: #14613
add config file parser for target device with json
ONE-DCO-1.0-Signed-off-by: Youxin Chen yx113.chen@samsung.com