[tools/onnx-subgraph] add guide in README.md for subgraphs verification#14821
Merged
seanshpark merged 4 commits intoSamsung:masterfrom Mar 12, 2025
Merged
[tools/onnx-subgraph] add guide in README.md for subgraphs verification#14821seanshpark merged 4 commits intoSamsung:masterfrom
seanshpark merged 4 commits intoSamsung:masterfrom
Conversation
guide for mse comparing of src model and multi sub models ONE-DCO-1.0-Signed-off-by: Youxin Chen <yx113.chen@samsung.com>
seanshpark
reviewed
Mar 11, 2025
tools/onnx_subgraph/README.md
Outdated
| └── NPUsubgraph1.onnx | ||
| ``` | ||
| ## Verify the subgraphs inference with original model file | ||
| compare the MSE of original inference result and subgraphs inference result |
Contributor
There was a problem hiding this comment.
Q) using indent (also in some other places in this file) will render as code block
is this intended?
Contributor
Author
There was a problem hiding this comment.
it is description, I have removed indent, thank you
seanshpark
reviewed
Mar 11, 2025
| -n scripts/subgraphs_ios.txt | ||
| ``` | ||
| output: | ||
| ```bash |
Contributor
There was a problem hiding this comment.
this seems text result, is it really needed to render as bash ?
Contributor
Author
There was a problem hiding this comment.
yes, it is log printing example, I have changed to text format, thank you
Contributor
There was a problem hiding this comment.
OK... I don't understand why render as bash but anyway you want it.
update as code review
update as code review
seanshpark
reviewed
Mar 12, 2025
annotate for the shell printing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related issue: #14534
historical full changes PR: #14613
guide for mse comparing of src model and multi sub models inference result
ONE-DCO-1.0-Signed-off-by: Youxin Chen yx113.chen@samsung.com