Skip to content

[tools/onnx-subgraph] Add readme.md for environment and existing code#14725

Merged
seanshpark merged 6 commits intoSamsung:masterfrom
chenyx113:onnx-subgraph-0220
Feb 21, 2025
Merged

[tools/onnx-subgraph] Add readme.md for environment and existing code#14725
seanshpark merged 6 commits intoSamsung:masterfrom
chenyx113:onnx-subgraph-0220

Conversation

@chenyx113
Copy link
Copy Markdown
Contributor

related issue: #14534
historical full changes PR: #14613

  1. add exception process for file open and IO
  2. add readme.md for previous submitting

ONE-DCO-1.0-Signed-off-by: Youxin Chen [email protected]

1. add exception process for file open and IO
2. add readme.md for previous submittings

ONE-DCO-1.0-Signed-off-by: Youxin Chen <[email protected]>
@chenyx113 chenyx113 marked this pull request as ready for review February 20, 2025 12:58
commit file read exception protection in future PR
[tools/onnx-subgraph] update format issue as review comments
Comment on lines +2 to +3
onnx-subgraph tool provides model auto partitionioning of onnx model to several sub models by
operator, performance and model size limitations, with the order and input / output names of
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
onnx-subgraph tool provides model auto partitionioning of onnx model to several sub models by
operator, performance and model size limitations, with the order and input / output names of
onnx-subgraph tool provides model auto partitionioning of onnx model to several sub models by
operator, performance and model size limitations, with the order and input / output names of

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz remove space at end of line

update the format checking issue in readme.md
@seanshpark
Copy link
Copy Markdown
Contributor

Current rendered output of readme is not what I expected to be, but you may want to go as-is.
Please check yourself with the output and confirm with a comment or update the file.

Update README.md format with target script type
@chenyx113
Copy link
Copy Markdown
Contributor Author

chenyx113 commented Feb 21, 2025

Current rendered output of readme is not what I expected to be, but you may want to go as-is. Please check yourself with the output and confirm with a comment or update the file.

I have tested, ```bash
can work with right format, thank you

Update README.md remove blank space
Copy link
Copy Markdown
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@seanshpark seanshpark merged commit 776522b into Samsung:master Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants