onnx-subgraph initial CMakeLists#14654
Conversation
|
I think you are not reading reviewers comments. |
|
from #14640 (comment)
I don't think |
|
#14654 (comment) is not satisfied. this is your commits: https://github.com/Samsung/ONE/pull/14654/commits |
thanks for review, I update the comment now, please help check |
I don't see any changes. Anyway I've triggered CIs. |
maybe some misunderstanding about comment body, I add it manually when creating PR refer to other PRs, is there any guide I can refer? sorry for making trouble |
search for git commands. I wrote to check https://github.com/Samsung/ONE/pull/14654/commits first item. |
I understand it now, the signed information should be included in the commit msg body, rather than add it manually when creating PR. I need to do following steps locally to solve current issue
please help check, thank you |
Yes :) |
ba83b55 to
b3f30c4
Compare
|
@seanshpark onnx-subgraph initial CMakeLists |
you have added commit title, but with no commit body. |
Initial committing of onnx-subgraph tool, only include the initial CMakeLists.txt in ./tools/onnx_subgraph ONE-DCO-1.0-Signed-off-by: Youxin Chen <yx113.chen@samsung.com>
b3f30c4 to
b8aedb0
Compare
thanks for suggestion, I have refered other commits and update again |
Brief introduction:
onnx-subgraph tool provides model auto partitioning of onnx model to several sub models by operator, performance and model size limitations, with the order and input / output names of sub models.
Purpose of current PR:
This is the initial PR of onnx-subgraph tool, only include the initial CMakeLists.txt in ./tools/onnx_subgraph, which is used to set up and debug the CI tools for auto building and testing new onnx-subgraph tool. the other codes and resources will be submitted step by step.
related issue of: #14534
historical full changes draft PR:
#14613
ONE-DCO-1.0-Signed-off-by: Youxin Chen yx113.chen@samsung.com