Skip to content

fix: improve inline code contrast inside greybox - closes #2677 #2678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
github-actions wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: improve inline code contrast inside greybox - closes #2677 #2678

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion components/embeds/boxEmbed.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@ import { Figure, inlineFigureDefaultItem, inlineFigureFields } from "./figure";
import { imageEmbedTemplate } from "./imageEmbed";
import { youtubeEmbedTemplate } from "./youtubeEmbed";

// Inline code inside greybox needs a white background to contrast with the gray container
const greyboxMarkdownComponents = {
...MarkdownComponentMapping,
code: (props: any) => <code className="bg-white py-1 px-2 rounded-sm" {...props} />,
};

function YakShaverIcon() {
return (
<div className="w-8 h-8 mr-4 flex items-start justify-center">
Expand Down Expand Up @@ -113,7 +119,7 @@ export function BoxEmbed(props: any) {
[&_img]:max-w-full [&_img]:h-auto
[&_p:last-child]:mb-0"
>
<TinaMarkdown content={data.body} components={MarkdownComponentMapping} />
<TinaMarkdown content={data.body} components={variant === "greybox" ? greyboxMarkdownComponents : MarkdownComponentMapping} />
</div>
</div>
</div>
Expand Down