Apply review feedback to the 4 R's of incident communication rule - #13103
Open
tomek-i wants to merge 1 commit into
Open
Apply review feedback to the 4 R's of incident communication rule#13103tomek-i wants to merge 1 commit into
tomek-i wants to merge 1 commit into
Conversation
- Drop the "Incidents - " title prefix, it doesn't group with any other rule - Condense the intro from 6 dense paragraphs to 3 - Fix full stops in lists, per /avoid-full-stops - Promote the emoji paragraphs to Heading 4s - Remove the "Final word" section - Rename "Cheatsheet" to "Summary", drop the emoji, add an <hr /> above Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Neq6zBKEwCyXY1HHacrPfd
Contributor
🔍 Preview PR ChangesView updated pages in edit mode:
|
github-actions
Bot
added
Age: 🥚 - New
Contributor
|
Howzit @tomek-i, This PR has been here a while. Did you know you should avoid merge debt?
Thanks! |
github-actions
Bot
added
Age: 🦖 - Extinct
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #13076, applying the review feedback that came in after the merge.
Changes
Incidentsprefix is noise and doesn't group with any other rule<endIntro />####<hr />added aboveThe full stop fix hit 3 lists, not 1: the "if you can't help" bullets, the 3 A's (item 1 was the only one ending in a stop), and the Resolve list (item 3 was multi-sentence without one).
The title change also updates the link text in
unplanned-outage-process. Theuriis unchanged, so no redirect is needed.Still outstanding
The rule has no images or video. A pair of redacted Teams screenshots (the vague back and forth vs. what good looks like) would be the strongest addition.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Neq6zBKEwCyXY1HHacrPfd