Repository navigation
Conversation
GitHub provides a bot called 'Dependabot' which can be used to automate version updates to Github actions. Adding this check monthly will trigger dependabot to create PRs with updates to github actions versions in use by SSSD. Reviewed-by: Pavel Březina <pbrezina@redhat.com> Reviewed-by: Tomáš Halman <thalman@redhat.com>
Reviewed-by: Justin Stephenson <jstephen@redhat.com>
Bumps [vapier/coverity-scan-action](https://github.com/vapier/coverity-scan-action) from 1.7.0 to 1.8.0. - [Release notes](https://github.com/vapier/coverity-scan-action/releases) - [Commits](vapier/coverity-scan-action@v1.7.0...v1.8.0) Reviewed-by: Justin Stephenson <jstephen@redhat.com>
We released a new SSSD beta version as 2.10.0-beta1, unfortunately this caused issues in the rpm build system as this value is set as the Version field but dash is not allowed in this field therefore `make rpms` was broken. Fedora guidelines requires to use ~ as a prerelease separator so two NVR versions compare correctly. For example: * 2.10.0 < 2.10.0-beta1 * 2.10.0~beta1 < 2.10.0 We will follow this guideline to make `make rpms` work again and to avoid any further rpm issues. Next GitHub release will also follow this guideline. Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Sumit Bose <sbose@redhat.com>
It turns out that git does not allow tilde in tag name therefore we need to keep using dash for upstream releases and tilde in downstream. Reviewed-by: Alexey Tikhonov <atikhono@redhat.com>
This automation can be manually triggered in "Actions" tab. - update translations - bump version number - create signed commits and tag - push the content to upstream repository - create new github release with autogenerated release notes Since release notes generated from out commit messages are not yet supported, the release is created as a draft. When created, we need to updated release notes manually and then publish the release. Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Justin Stephenson <jstephen@redhat.com>
Jobs inside this workflow are skipped if pull request touches only system tests and no other files, so it is not run when not needed (system tests can not break make). It is however run for all changes when pushed to the target branch to always have the latest status available. Reviewed-by: Justin Stephenson <jstephen@redhat.com> Reviewed-by: Tomáš Halman <thalman@redhat.com>
Pull request that only modify test do not need to run the whole test suite, only the test that were actually touched. Reviewed-by: Justin Stephenson <jstephen@redhat.com> Reviewed-by: Tomáš Halman <thalman@redhat.com>
Reviewed-by: Justin Stephenson <jstephen@redhat.com> Reviewed-by: Tomáš Halman <thalman@redhat.com>
ikerexxe
force-pushed
the
sync-ci-sssd-2-9-4
branch
from
October 13, 2025 09:16
097ca06 to
569f050
Compare
|
Failed to load packit config file: For more info, please check out the documentation or contact the Packit team. You can also use our CLI command |
ikerexxe
force-pushed
the
sync-ci-sssd-2-9-4
branch
from
October 13, 2025 10:09
569f050 to
60b56d5
Compare
ikerexxe
force-pushed
the
sync-ci-sssd-2-9-4
branch
from
October 16, 2025 14:07
60b56d5 to
9c33e87
Compare
|
Failed to load packit config file: For more info, please check out the documentation or contact the Packit team. You can also use our CLI command |
ikerexxe
force-pushed
the
sync-ci-sssd-2-9-4
branch
3 times, most recently
from
October 16, 2025 15:26
ef298bd to
b72429f
Compare
ikerexxe
marked this pull request as ready for review
October 16, 2025 16:44
Contributor
Is |
In theory new API might be somewhat better. But: 1) it's fairly new: `ares_search_dnsrec()` and `ares_query_dnsrec()` were introduced in c-ares-1.28 while even CentOS Stream 10 has c-ares-1.25, so SSSD would need to support (fallback) old API anyway. 2) SSSD doesn't make heavy use of DNS, so potential performance improvements are really negligible. On the other hand, old API/ABI will be available for a long time: c-ares/c-ares#732 (comment) For those reasons it's not worth the effort to port code to new API right now. Reviewed-by: Alejandro López <allopez@redhat.com> Reviewed-by: Tomáš Halman <thalman@redhat.com>
with `sss_erase_mem_securely()` Resolves: SSSD#7606 Reviewed-by: Alejandro López <allopez@redhat.com> Reviewed-by: Tomáš Halman <thalman@redhat.com>
In OpenSSL 3.0 some of the calls we currently use in the utility functions to covert the public key from a X.509 certificate into an ssh public key got deprecated. This patch replaces them if OpenSSL 3.0 or newer is used. In contrast to the older calls which just returned references the new calls return the requested data in freshly allocated memory. To keep it consistent the data referenced by the old calls are copied into allocated memory as well. Resolves: SSSD#5861 Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com>
:packaging:Support of OpenSSL older than 1.0.1 was dropped Reviewed-by: Sumit Bose <sbose@redhat.com>
Don't include <openssl/core_names.h> header if OpenSSL older 3.0 is used. Fix compile typos for build with OpenSSL 1.1. Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Sumit Bose <sbose@redhat.com>
This test was previously unstable, since it is possible that the contents of the log file were not yet fully written to the disk. We need to stop SSSD to ensure that all logs are flushed. Reviewed-by: Alexey Tikhonov <atikhono@redhat.com>
Since curl version 7.85.0 CURLOPT_PROTOCOLS is deprecated and should be replaced by CURLOPT_PROTOCOLS_STR. Resolves: SSSD#6922 Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Pavel Březina <pbrezina@redhat.com>
Reviewed-by: Tomáš Halman <thalman@redhat.com>
Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
This test has been refactored in master and the current implementation for this branch isn't valid anymore. Porting the refactored version isn't an option. Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
When only system test files are touched in a PR, the get-changed.sh script fails due to -o pipefail option being added by GH action shell built-in. https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#defaultsrunshell Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Tomáš Halman <thalman@redhat.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com> Reviewed-by: Tomáš Halman <thalman@redhat.com>
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5 to 6. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v5...v6) Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com>
ikerexxe
force-pushed
the
sync-ci-sssd-2-9-4
branch
from
October 30, 2025 08:59
46850db to
d02add3
Compare
Member
|
Pushed PR: #8139
|
This was referenced Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of #8105 sync CI for sssd-2-9-4 branch. The first part of the PR contains commits that are already available in master, the second part contains the changes I've made to make CI green and the changes to target centos-8, or centos-9 depending on the availability, in CI.
From now on the following jobs will be run in sssd-2-9-4 branch:
All other jobs have been removed as they don't make sense anymore.