Skip to content

Specify Python minor version in homebrew formula #3344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jstvz merged 2 commits into from
Aug 23, 2022
Merged

Specify Python minor version in homebrew formula #3344

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d4de85
Add Rust as build dependency in homebrew formula
jstvz Aug 23, 2022
3e3c33a
Update utility/build-homebrew.sh
jstvz Aug 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions utility/build-homebrew.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ echo " "
echo "=> Compiling pip requirements including hashes..."
echo " "
echo "cumulusci==$PACKAGE_VERSION" > "$REQS_IN_FILE"
pip-compile "$REQS_IN_FILE" -o "$REQS_FILE" --generate-hashes
# For a longish thread on why `allow-unsafe`, see https://github.com/pypa/pip/issues/6459
# Here, we're adding it to collect setuptools-rust for the cryptography library.
pip-compile "$REQS_IN_FILE" -o "$REQS_FILE" --generate-hashes --allow-unsafe

echo " "
echo "=> Writing Homebrew Formula to ${OUT_FILE}..."
Expand All @@ -34,7 +36,8 @@ class Cumulusci < Formula
homepage "https://github.com/SFDO-Tooling/CumulusCI"
url $PACKAGE_URL
sha256 $PACKAGE_SHA
head "https://github.com/SFDO-Tooling/CumulusCI.git"
license "BSD-3-Clause"
head "https://github.com/SFDO-Tooling/CumulusCI.git", branch: "main"

depends_on "python@3.9"

Expand All @@ -48,7 +51,8 @@ $(cat "$REQS_FILE")
REQS

File.write("requirements.txt", reqs)
system "python3", "-m", "pip", "install", "-r", "requirements.txt", "--require-hashes", "--no-deps", "--ignore-installed", "--prefix", libexec
## Python@3.9 no longer includes python3 https://github.com/Homebrew/homebrew-core/pull/107517
system "python3.9", "-m", "pip", "install", "-r", "requirements.txt", "--require-hashes", "--no-deps", "--ignore-installed", "--prefix", libexec

bin.install Dir["#{libexec}/bin/cci"]
bin.install Dir["#{libexec}/bin/snowfakery"]
Expand Down