Skip to content

Fix SMS Spam project link in MLQuality#4

Open
philippedeb wants to merge 2 commits into
SERG-Delft:mainfrom
philippedeb:fix_smsspam_project_link
Open

Fix SMS Spam project link in MLQuality#4
philippedeb wants to merge 2 commits into
SERG-Delft:mainfrom
philippedeb:fix_smsspam_project_link

Conversation

@philippedeb

Copy link
Copy Markdown
Contributor

Issue

The link referring to the SMS Spam project in the following places is not working properly:

image

image

It results in https://se.ewi.tudelft.nl/material/projects/sms-spam/, a 404:

image

Solution

Changed the link to include the /remla prefix, which leads to the right place: https://se.ewi.tudelft.nl/remla/material/projects/sms-spam/.

@proksch proksch left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "correct" fix is to use a, for example, {%link material/projects/sms-spam.md%}. When doing so, Jekyll will complain, when the link is changed/removed.

@philippedeb philippedeb requested a review from proksch July 16, 2023 09:47
@philippedeb

Copy link
Copy Markdown
Contributor Author

Broken links in Markdown have been updated to {% link ... %} instead of the previous Liquid code {{ ... | absolute_path }}. Should route to the correct material now and also check whether the links exist before building/serving the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants