Fix invalid for attribute on label elements in EmailPreferences.js - #2174
Open
marlware wants to merge 1 commit into
Open
Fix invalid for attribute on label elements in EmailPreferences.js#2174marlware wants to merge 1 commit into
for attribute on label elements in EmailPreferences.js#2174marlware wants to merge 1 commit into
Conversation
JSX requires htmlFor instead of for; using the raw HTML attribute name triggers a React DOM property warning at runtime.
Collaborator
|
this is cool, thanks if you wanna contribute to the website lets do something more interesting, we can discuss in discord |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSX requires
htmlForinstead offor. At runtime, using the raw HTML attributeforname triggers a React DOM property warning.