Skip to content

Add more NuGraph2 variables to CAFs#183

Open
rtriozzi wants to merge 5 commits intodevelopfrom
feature/rtriozzi_NuGraph2_MoveVars
Open

Add more NuGraph2 variables to CAFs#183
rtriozzi wants to merge 5 commits intodevelopfrom
feature/rtriozzi_NuGraph2_MoveVars

Conversation

@rtriozzi
Copy link
Copy Markdown
Contributor

@rtriozzi rtriozzi commented Jan 12, 2026

This PR adds some plane-by-plane slice-level variables to the CAFs, based on the predictions from NuGraph2.
Specifically:

  • the number of hits tagged by NuGraph2 for each category in the slice (e.g., shr_hits for the Shower category);
  • ng_vtx_hip_hits: the number of "HIP" hits tagged by NuGraph2 near the reconstructed interaction vertex. Wire and tick allowed distances are configurable. Standard is 10 wires and 50 ticks;
  • unclustered_shr_hits: the number of hits tagged as "shower" by NuGraph2 in the slice, that are not associated to any reconstructed PFP.

Associated PRs


Checklist

  • Have you run git fetch and pulled the latest changes from the branch you're basing your PR against? Will do, after review.
  • If you're adding new classes, have you added them to classes_def.xml in the relevant directory?
  • Have you added a checksum in classes_def.xml to any and all new classes you're implementing, and rebuilt?
  • If you're updating classes, have you incremented the ClassVersion by one compared to develop in classes_def.xml?

Copy link
Copy Markdown
Contributor

@cerati cerati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks!

@kjplows kjplows moved this from Open pull requests to Partially reviewed in SBN software development Feb 11, 2026
@kjplows
Copy link
Copy Markdown
Contributor

kjplows commented Feb 11, 2026

Sorry to add to the bump spam @PetrilloAtWork, could you please take a look at this? Thanks!

@kjplows kjplows moved this from Todo to In Progress in PR archaeology Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress
Status: Partially reviewed

Development

Successfully merging this pull request may close these issues.

3 participants