Merged
Conversation
…s to Object. Fix compatibility with Logging
…ss has duplicated range' warning
Collaborator
|
@pitbulk these changes look fine to me. |
lib/ruby_saml.rb
Outdated
| Logging = ::RubySaml::Logging | ||
| end | ||
| end | ||
| end No newline at end of file |
Collaborator
There was a problem hiding this comment.
Run rubocop -A to fix indents
…ib::Inflate by limiting the maximum decompressed size. The data is now inflated in chunks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix several typos on the documentation and code
Add to the README how to force SP-Initiate flow and Prevent Reply Attacks
Adjust OneLogin namespace compatibility, defining Module instead of Alias to Object.
This alias was very broad: it makes every constant under Object appear as if it lived under OneLogin::. For example:
and could hide bugs or conflict with apps that already define OneLogin.
Fix compatibility with Logging
Old code called OneLogin::RubySaml::Logging.logger = ....
New code expects RubySaml::Logging.logger = ....
The compat alias OneLogin = Object does not expose Logging under OneLogin::RubySaml
will now raise NameError instead of continuing to work.
This is a backwards‑compat break.
Adjust regular expression for base64_encoded? to avoid 'character class has duplicated range' warning
Improve the inflate method. Prevent potential DoS vulnerability in Zlib::Inflate by limiting the maximum decompressed size. The data is now inflated in chunks.