Only try falling back to mkfifoat() if it is available#901
Open
ribbons wants to merge 1 commit into
Open
Conversation
If MKNOD_CREATES_FIFOS is not defined by configure (such as when cross-compiling), mkfifo() is available but mkfifoat() is not then compilation fails since 30656c5. Add a function check for mkfifoat and update the preprocessor conditional that wraps the call to it to reference HAVE_MKFIFOAT.
ribbons
added a commit
to ribbons/android-rsync
that referenced
this pull request
May 21, 2026
Compilation of v3.4.3 fails due to mkfifoat() being referenced but it is not available on Android until API level 23 (we are targeting 21 and above). Add patch (submitted at RsyncProject/rsync#901 for the consideration of upstream) to test specifically for the existence of mkfifoat() before trying to call it. Extend the build script and workflow to automatically apply patches in the root of the repository to the fetched source and reference the number of patches in the version number of the release.
ribbons
added a commit
to ribbons/android-rsync
that referenced
this pull request
May 21, 2026
Compilation of v3.4.3 fails due to mkfifoat() being referenced but it is not available on Android until API level 23 (we are targeting 21 and above). Add patch (submitted at RsyncProject/rsync#901 for the consideration of upstream) to test specifically for the existence of mkfifoat() before trying to call it. Extend the build script and workflow to automatically apply patches in the root of the repository to the fetched source and reference the number of patches in the version number of the release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
MKNOD_CREATES_FIFOSis not defined by configure (such as when cross-compiling),mkfifo()is available butmkfifoat()is not then compilation fails since 30656c5.(I discovered this when trying to cross-compile v3.4.3 for Android, targeting API level 21 which provides
mkfifo()but notmkfifoat()).This PR adds a configure function check for
mkfifoatand updates the preprocessor conditional that wraps the call to it in syscall.c to referenceHAVE_MKFIFOAT.