feat(css-in-js): Allow passing a target document to rule attacher#1933
Merged
feat(css-in-js): Allow passing a target document to rule attacher#1933
document to rule attacher#1933Conversation
🦋 Changeset detectedLatest commit: 277c884 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gabriellsh
force-pushed
the
fix/cssInJsDocument
branch
from
bd190bc to
5571d3a
Compare
Member
Author
|
@coderabbitai review |
gabriellsh
force-pushed
the
fix/cssInJsDocument
branch
from
01e9866 to
ce7cd2f
Compare
tassoevan
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Today
css-in-jsdirectly references thewindow.documentproperty in the style attachers. This is fine for our current use, but in some situations (such as portals inside popup windows) this can cause a mismatch between the document that the element is being rendered, and the document where the styles are being inserted.This PR introduces an option to pass
documentas parameter, allowing for different target documents to be used.Issue(s)
PRD-323
Further comments