feat: Improve action unadvertising (backport #1248)#1252
Open
mergify[bot] wants to merge 2 commits into
Open
Conversation
* Improve logging on send_action_goal fail * Reject new goals after action was unadversited * Abort action goals on shutdown * Schedule destruction of action server after last goal finishes * Expand unadvertise action test (cherry picked from commit cfd0646) # Conflicts: # rosbridge_library/src/rosbridge_library/capabilities/advertise_action.py
Author
|
Cherry-pick of cfd0646 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public API Changes
None
Description
Previously, action servers were never actually destroyed and just left hanging. This PR improves the logic so that now, when an action gets unadvertised:
The test confirms that the user can advertise the action, unadvertise the action and then advertise the action with the same name again.
I'm still not sure whether
action_server.destroy()is perfectly safe but I didn't experience any crashes when testing it.This is an automatic backport of pull request #1248 done by Mergify.