Skip to content

[workspace] Update styleguide for python 3.12 support#21084

Merged
jwnimmer-tri merged 1 commit into
RobotLocomotion:masterfrom
svenevs:fix/styleguide-for-python-3.12
Mar 1, 2024
Merged

[workspace] Update styleguide for python 3.12 support#21084
jwnimmer-tri merged 1 commit into
RobotLocomotion:masterfrom
svenevs:fix/styleguide-for-python-3.12

Conversation

@svenevs
Copy link
Copy Markdown
Contributor

@svenevs svenevs commented Mar 1, 2024

Relates: #20294, #21013, RobotLocomotion/styleguide#54


This change is Reviewable

@svenevs svenevs added the status: single reviewer ok https://drake.mit.edu/reviewable.html label Mar 1, 2024
Copy link
Copy Markdown
Contributor Author

@svenevs svenevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@jwnimmer-tri for feature review please. Probably +(status: single reviewer ok) too, the other reviewer being CI running the fixes locally here.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: LGTM missing from assignee jwnimmer-tri(platform), missing label for release notes (waiting on @svenevs)

@svenevs svenevs added the release notes: none This pull request should not be mentioned in the release notes label Mar 1, 2024
Copy link
Copy Markdown
Collaborator

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: both.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee jwnimmer-tri(platform)

@jwnimmer-tri jwnimmer-tri merged commit 67afbfb into RobotLocomotion:master Mar 1, 2024
@svenevs svenevs deleted the fix/styleguide-for-python-3.12 branch March 1, 2024 22:06
jwnimmer-tri pushed a commit to jwnimmer-tri/drake that referenced this pull request Apr 1, 2024
RussTedrake pushed a commit to RussTedrake/drake that referenced this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: none This pull request should not be mentioned in the release notes status: single reviewer ok https://drake.mit.edu/reviewable.html

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants