[macOS] Fix python 3.11 testing issues#18786
Conversation
|
@drake-jenkins-bot mac-arm-monterey-clang-bazel-experimental-release please. |
xuchen-han
left a comment
xuchen-han
left a comment
There was a problem hiding this comment.
+@xuchenhan-tri
Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, needs at least two assigned reviewers, missing label for release notes (waiting on @svenevs)
bindings/pydrake/common/test/deprecation_autocomplete_test.py line 55 at r1 (raw file):
"__getattr__(", "__getattribute__(", "__getstate__(",
This seems to appease mac but upset jammy
xuchen-han
left a comment
xuchen-han
left a comment
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1.
Reviewable status: 1 unresolved discussion, needs at least two assigned reviewers, missing label for release notes (waiting on @svenevs)
Follow-up to RobotLocomotion#18262. - deprecation_autocomplete_test: add __getstate__(, refs: https://docs.python.org/3/library/pickle.html#object.__getstate__ Changed in version 3.11: Added the default implementation of the __getstate__() method in the object class. - styleguide: temporarily mark the failing test as manual to unblock CI, proper fix to adjust import paths TBD.
svenevs
force-pushed
the
fix/macos-py-311
branch
from
5c06655 to
5a75bf4
Compare
|
@drake-jenkins-bot mac-arm-monterey-clang-bazel-experimental-release please. |
svenevs
added
the
release notes: fix
jwnimmer-tri
left a comment
jwnimmer-tri
left a comment
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: 1 unresolved discussion, needs at least two assigned reviewers (waiting on @svenevs)
svenevs
left a comment
svenevs
left a comment
There was a problem hiding this comment.
+@jwnimmer-tri for platform everything is just about 🟢
Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: 1 unresolved discussion (waiting on @xuchenhan-tri)
tools/workspace/styleguide/BUILD.bazel line 10 at r2 (raw file):
size = "small", srcs = ["@styleguide//:cpplint_unittest"], # TODO(jwnimmer-tri): macOS python 3.11 began having import issues because
FYI @jwnimmer-tri I put this in your camp per discussion on slack, there is no ticket tracking it currently.
bindings/pydrake/common/test/deprecation_autocomplete_test.py line 55 at r1 (raw file):
Previously, xuchenhan-tri wrote…
This seems to appease mac but upset jammy
Done, removed -- that was a silly mistake on my part. The code now only adds __getstate__ when we are >= python 3.11.
svenevs
left a comment
svenevs
left a comment
There was a problem hiding this comment.
Reviewed all commit messages.
Dismissed @xuchenhan-tri from a discussion.
Reviewable status:complete! all discussions resolved, LGTM from assignees jwnimmer-tri(platform),xuchenhan-tri(platform) (waiting on @svenevs)
|
No end-user changes here, +(release notes: none). |
jwnimmer-tri
added
release notes: none
Follow-up to RobotLocomotion#18262. - deprecation_autocomplete_test: add __getstate__(, refs: https://docs.python.org/3/library/pickle.html#object.__getstate__ Changed in version 3.11: Added the default implementation of the __getstate__() method in the object class. - styleguide: temporarily mark the failing test as manual to unblock CI, proper fix to adjust import paths TBD.
3 participants
Follow-up to #18262.
deprecation_autocomplete_test: add getstate(, refs: https://docs.python.org/3/library/pickle.html#object.__getstate__
Changed in version 3.11: Added the default implementation of the getstate() method in the object class.
styleguide: temporarily mark the failing test as manual to unblock CI, proper fix to adjust import paths TBD.
This change is