Skip to content

[workspace] Update pybind11 to include python@3.11 patches#18297

Merged
svenevs merged 1 commit into
RobotLocomotion:masterfrom
svenevs:test/pybind11-3.11-patch
Nov 10, 2022
Merged

[workspace] Update pybind11 to include python@3.11 patches#18297
svenevs merged 1 commit into
RobotLocomotion:masterfrom
svenevs:test/pybind11-3.11-patch

Conversation

@svenevs
Copy link
Copy Markdown
Contributor

@svenevs svenevs commented Nov 10, 2022

Relates: RobotLocomotion/pybind11#60, #18262.


This change is Reviewable

@svenevs
Copy link
Copy Markdown
Contributor Author

svenevs commented Nov 10, 2022

@drake-jenkins-bot mac-arm-monterey-unprovisioned-clang-wheel-experimental-snopt-mosek-release please.
@drake-jenkins-bot mac-x86-monterey-unprovisioned-clang-wheel-experimental-snopt-mosek-release please.
@drake-jenkins-bot linux-focal-unprovisioned-gcc-wheel-experimental-snopt-mosek-release please.

Copy link
Copy Markdown
Contributor Author

@svenevs svenevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@jwnimmer-tri for review please (part of the other two PRs).

Reviewable status: LGTM missing from assignee jwnimmer-tri(platform), needs at least two assigned reviewers, missing label for release notes (waiting on @jwnimmer-tri)

@jwnimmer-tri
Copy link
Copy Markdown
Collaborator

The CI testing choice looks correct. Once it passes, you can merge the pybind11 PR and then refresh the details here.

@jwnimmer-tri jwnimmer-tri added release notes: none This pull request should not be mentioned in the release notes status: single reviewer ok https://drake.mit.edu/reviewable.html labels Nov 10, 2022
Copy link
Copy Markdown
Collaborator

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: +(status: single reviewer ok) +(release notes: none) pending sha fixup.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 2 unresolved discussions (waiting on @svenevs)


tools/workspace/pybind11/repository.bzl line 7 at r1 (raw file):

# Using the `drake` branch of this repository.
_REPOSITORY = "svenevs/pybind11"

Suggestion:

RobotLocomotion

tools/workspace/pybind11/repository.bzl line 13 at r1 (raw file):

# and if it has changed, then update the version number in the two
# pybind11-*.cmake files in the current directory to match.
_COMMIT = "3d90c7d32ea615148e7ec1ac609f773f5580f478"

Suggestion:

36695db542e1c34f6db7ca3ebb0415de30762395

@svenevs svenevs force-pushed the test/pybind11-3.11-patch branch from d430cdf to 7c64019 Compare November 10, 2022 21:05
@svenevs
Copy link
Copy Markdown
Contributor Author

svenevs commented Nov 10, 2022

@drake-jenkins-bot mac-arm-monterey-unprovisioned-clang-wheel-experimental-snopt-mosek-release please.
@drake-jenkins-bot mac-x86-monterey-unprovisioned-clang-wheel-experimental-snopt-mosek-release please.
@drake-jenkins-bot linux-focal-unprovisioned-gcc-wheel-experimental-snopt-mosek-release please.

Copy link
Copy Markdown
Contributor Author

@svenevs svenevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to merge once CI passes (one final sanity check, worth it).

Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee jwnimmer-tri(platform) (waiting on @jwnimmer-tri)


tools/workspace/pybind11/repository.bzl line 7 at r1 (raw file):

# Using the `drake` branch of this repository.
_REPOSITORY = "svenevs/pybind11"

Done.


tools/workspace/pybind11/repository.bzl line 13 at r1 (raw file):

# and if it has changed, then update the version number in the two
# pybind11-*.cmake files in the current directory to match.
_COMMIT = "3d90c7d32ea615148e7ec1ac609f773f5580f478"

Done.

Copy link
Copy Markdown
Collaborator

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee jwnimmer-tri(platform) (waiting on @svenevs)

@svenevs svenevs merged commit a037acf into RobotLocomotion:master Nov 10, 2022
@svenevs svenevs deleted the test/pybind11-3.11-patch branch November 10, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: none This pull request should not be mentioned in the release notes status: single reviewer ok https://drake.mit.edu/reviewable.html

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants