Fix: price column sorting in offers table - #2455
Conversation
juanfradb
left a comment
There was a problem hiding this comment.
utACK bd0e1e3\n\nReviewed the one-file diff. The comparator now derives the sortable value from the same calculated price path used for rendering, instead of the raw field that is absent/null in row data.\n\nValidation run locally:\n- npx eslint src/components/BookTable/index.tsx\n- npm run build\n\nBuild completed with existing bundle-size warnings only. I did not run an end-to-end browser repro.
|
Small correction to my review text above: the missing raw field name is |
bd0e1e3 to
88c1b91
Compare
|
Hi @kanishka0411 sorry for taking this long. Can you please fix the linterns? with that we should be good to go |
No worries! Fixed the linter check .Please have a look :-) |
|
Ey @kanishka0411 sorry we just added some extra Ts type linterns and now they are poping out |
|
All good! TypeScript linter errors are fixed now :) |
|
Also, was going through my wallet and remembered- the tip from #2405 , maybe you already sent it and I missed it? Could you confirm 🙏 |
What does this PR do?
Fixes #2454
This PR introduces/refactors/...
Fixes price column sorting in the offers table. The displayed price was calculated on the fly but sorting used the raw field which was always null, so added a sort comparator that uses the actual calculated price.
Screen.Recording.2026-03-22.at.8.15.30.PM.mov
Checklist before merging
pip install pre-commit, thenpre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.