Test Codex inline review detection - #32
Conversation
There was a problem hiding this comment.
The change introduces a functional regression in scripts/ci/mtr.sh: command-line arguments are discarded, contradicting the wrapper’s documented interface and preventing targeted MTR runs. Please restore argument forwarding with "$@".
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
ab.chatgpt.com
To allow these domains, add them to the network.allowed list in your workflow frontmatter:
network:
allowed:
- defaults
- "ab.chatgpt.com"See Network Configuration for more information.
Generated by Codex PR Review for #32 · codex · gpt56 · 3.91 AIC · ⌖ 2.19 AIC · ⊞ 18.6K
Comment /codex to run again
| cd "$BUILD_DIR/mysql-test" | ||
|
|
||
| exec ./mtr "$@" | ||
| exec ./mtr |
There was a problem hiding this comment.
This drops every argument supplied to the wrapper, despite the usage text promising that scripts/ci/mtr.sh --suite=innodb ... passes raw args to ./mtr. Any CI or developer invocation that selects suites, tests, or other MTR options will silently run the default selection instead. Please retain "$@" here.
73ee812 to
0c06b42
Compare
0c06b42 to
9a561c7
Compare
There was a problem hiding this comment.
The existing unresolved inline finding remains valid: scripts/ci/mtr.sh now discards every caller-supplied MTR argument, so suite/test selection and other options silently stop working. Restore exec ./mtr "$@". No additional findings.
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
ab.chatgpt.com
To allow these domains, add them to the network.allowed list in your workflow frontmatter:
network:
allowed:
- defaults
- "ab.chatgpt.com"See Network Configuration for more information.
Generated by Codex PR Review for #32 · codex · gpt56 · 19.2 AIC · ⌖ 11.1 AIC · ⊞ 12.1K
Comment /codex to run again
Test-only PR for the Codex review workflow. It intentionally drops MTR argument forwarding so the reviewer has a concrete, changed-line regression to identify. Do not merge.