Skip to content

Test Codex inline review detection - #32

Open
RidhaOracle wants to merge 1 commit into
trunkfrom
codex/test-inline-review
Open

Test Codex inline review detection#32
RidhaOracle wants to merge 1 commit into
trunkfrom
codex/test-inline-review

Conversation

@RidhaOracle

Copy link
Copy Markdown
Owner

Test-only PR for the Codex review workflow. It intentionally drops MTR argument forwarding so the reviewer has a concrete, changed-line regression to identify. Do not merge.

@github-actions github-actions Bot added the Build Changes touching build or GitHub automation label Sep 3, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change introduces a functional regression in scripts/ci/mtr.sh: command-line arguments are discarded, contradicting the wrapper’s documented interface and preventing targeted MTR runs. Please restore argument forwarding with "$@".

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • ab.chatgpt.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "ab.chatgpt.com"

See Network Configuration for more information.

Generated by Codex PR Review for #32 · codex · gpt56 · 3.91 AIC · ⌖ 2.19 AIC · ⊞ 18.6K
Comment /codex to run again

Comment thread scripts/ci/mtr.sh
cd "$BUILD_DIR/mysql-test"

exec ./mtr "$@"
exec ./mtr

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This drops every argument supplied to the wrapper, despite the usage text promising that scripts/ci/mtr.sh --suite=innodb ... passes raw args to ./mtr. Any CI or developer invocation that selects suites, tests, or other MTR options will silently run the default selection instead. Please retain "$@" here.

@github-actions github-actions Bot added the Build Passed PR build passed label Sep 3, 2026
@RidhaOracle
RidhaOracle force-pushed the codex/test-inline-review branch from 73ee812 to 0c06b42 Compare September 3, 2026 19:23
@github-actions github-actions Bot added Build Passed PR build passed and removed Build Passed PR build passed labels Sep 3, 2026
@RidhaOracle
RidhaOracle force-pushed the codex/test-inline-review branch from 0c06b42 to 9a561c7 Compare September 3, 2026 20:10
@github-actions github-actions Bot added Build Passed PR build passed and removed Build Passed PR build passed labels Sep 3, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing unresolved inline finding remains valid: scripts/ci/mtr.sh now discards every caller-supplied MTR argument, so suite/test selection and other options silently stop working. Restore exec ./mtr "$@". No additional findings.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • ab.chatgpt.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "ab.chatgpt.com"

See Network Configuration for more information.

Generated by Codex PR Review for #32 · codex · gpt56 · 19.2 AIC · ⌖ 11.1 AIC · ⊞ 12.1K
Comment /codex to run again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build Passed PR build passed Build Changes touching build or GitHub automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant