Fix "Controller" suffix removal#5312
Open
marius-hofmann wants to merge 1 commit into
Open
Conversation
* Only remove last occurrence of "Controller" when processing controller name in `WebApiOpenApiDocumentGenerator`
Author
|
@lahma thanks for having a look at my PR. I'm sorry, that the tests failed, but I think, the failing is not caused by my changes. It seems like http://petstore.swagger.io/v2/swagger.json returned a 502 during the test execution. I don't know if this is a permanent issue or just a short service outage. Could you re-run the checks in order to verify if there is a more permanent problem? |
Owner
|
@marius-hofmann should we do the same for the asp.net core implementation as well? |
Author
@RicoSuter What exactly do you mean? I could not find another position which uses this logic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebApiOpenApiDocumentGenerator