Skip to content

Adds a setting-option to add swagger plugins.#4922

Open
jarleli wants to merge 14 commits into
RicoSuter:masterfrom
jarleli:SupportSwaggerPlugins
Open

Adds a setting-option to add swagger plugins.#4922
jarleli wants to merge 14 commits into
RicoSuter:masterfrom
jarleli:SupportSwaggerPlugins

Conversation

@jarleli
Copy link
Copy Markdown

@jarleli jarleli commented Jun 24, 2024

I wanted a way to add swagger plugins through NSwag.

Changed the signature of GetCustomScriptHtml to allow reuse.
Added setting for plugin with name and script path.
Script must be hosted in your application and reachable by swagger.

@jarleli
Copy link
Copy Markdown
Author

jarleli commented Jun 24, 2024

resolves #4921

@jarleli
Copy link
Copy Markdown
Author

jarleli commented Jun 26, 2024

Fixes #4921

Copy link
Copy Markdown
Contributor

@Saibamen Saibamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge latest master branch and fix conflicts after https://github.com/RicoSuter/NSwag/pull/5031/files

Comment thread src/NSwag.AspNetCore/SwaggerUi/index.html Outdated
Comment thread src/NSwag.AspNetCore/SwaggerUi/index.html Outdated
Comment thread src/NSwag.AspNet.Owin/SwaggerUi/index.html Outdated
Comment thread src/NSwag.AspNet.Owin/SwaggerUi/index.html Outdated
Comment thread src/NSwag.AspNetCore/SwaggerUiSettings.cs
Comment thread src/NSwag.AspNetCore/SwaggerUiSettingsBase.cs
Comment thread src/NSwag.AspNetCore/SwaggerUiSettingsBase.cs Outdated
Comment thread src/NSwag.AspNetCore/SwaggerUiSettingsBase.cs
Comment thread src/NSwag.AspNetCore/SwaggerUiSettingsBase.cs Outdated
Comment thread src/NSwag.AspNetCore/SwaggerUiSettingsBase.cs Outdated
@Saibamen
Copy link
Copy Markdown
Contributor

Fixes #4921

To link PR and issues, this text needs to be in the first comment.

@RicoSuter
Copy link
Copy Markdown
Owner

If you fix the conflicts, i think we can merge this.

@Mike-Logit
Copy link
Copy Markdown

@jarleli is there any chance you could fix the conflicts and get this merged? Or someone else because this feature would be brilliant.

jarleli and others added 11 commits May 1, 2025 18:04
Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
@jarleli
Copy link
Copy Markdown
Author

jarleli commented May 1, 2025

It's been a year since I did this, so I'm kind of out of the loop and a bunch of stuff has happened in the repo since.
Were there no other issues? Is it done?

@jarleli jarleli requested a review from Saibamen May 1, 2025 18:02
Adhere to code standard enforced
@jarleli
Copy link
Copy Markdown
Author

jarleli commented May 10, 2025

I think this is only waiting for a new workflow run.

Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
@ben-voss
Copy link
Copy Markdown

I would really like to see this merged and released. What can I do to help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants