Skip to content

Feature/vcsha - #114

Closed
deweysasser wants to merge 3 commits into
RichiH:masterfrom
deweysasser:feature/vcsha
Closed

Feature/vcsha#114
deweysasser wants to merge 3 commits into
RichiH:masterfrom
deweysasser:feature/vcsha

Conversation

@deweysasser

Copy link
Copy Markdown

Implement a wrapper around vcsh which allows applying vcsh to arbitrary file locations.

Dewey Sasser added 3 commits March 4, 2014 13:23
@andyleejordan

Copy link
Copy Markdown
Contributor

I think the functionality implemented here could be merged into vcsh itself, rather than done in a wrapper script. I like the idea, but it'd be cleaner to have vcsh detect the .vcsh file, and set the necessary variables automatically. It already sets to to defaults if they're not set in any of the current sources, I think it'd be as easy as adding ./.vcsh as a config source... I'll try it tomorrow.

@RichiH

RichiH commented Mar 5, 2014

Copy link
Copy Markdown
Owner

As stated in #110 I would also prefer to fold this back into vcsh proper.

Having a helper script is possible, but this should really be native.

I think either extending the existing config with per-repo configs or introducing distinct files for repo configuration would be the best approach.

Once again, this gets us uncomfortably close to a point at which a rewrite in a higher-level language looks more and more interesting... OTOH, as it stands, vcsh is as portable as humanly possible, today...

@deweysasser

Copy link
Copy Markdown
Author

Got it. Sorry, I was thinking primarily about source control and missed your point. What you say makes sense.

As it seems Andrew is going to work on this today I'll hold off to avoid duplication of effort. If he decided not to I'll give it a shot. I looked through the vcsh script yesterday and the code seems pretty clear.

I do strongly value the portability. I have been using vcsh on cygwin, Ubuntu and CentOS and it works very nicely. I'm recommending it to a colleague who is primarily Mac based.

On March 5, 2014 5:16:24 AM EST, Richard Hartmann notifications@github.com wrote:

As stated in #110 I would also
prefer to fold this back into vcsh proper.

Having a helper script is possible, but this should really be native.

I think either extending the existing config with per-repo configs or
introducing distinct files for repo configuration would be the best
approach.

Once again, this gets us uncomfortably close to a point at which a
rewrite in a higher-level language looks more and more interesting...
OTOH, as it stands, vcsh is as portable as humanly possible, today...


Reply to this email directly or view it on GitHub:
#114 (comment)

Dewey

@RichiH

RichiH commented Mar 6, 2014

Copy link
Copy Markdown
Owner

Hi,

is either of you tackling this?

Thanks,
RIchard

@deweysasser

Copy link
Copy Markdown
Author

On 3/6/2014 10:57 AM, Richard Hartmann wrote:

Hi,

is either of you tackling this?

I have not, but I will if that's not going to conflict with Andrew's work.

D

@andyleejordan

Copy link
Copy Markdown
Contributor

I'll be giving it a go tomorrow night / Saturday, too much homework in the way until then.

@andyleejordan

Copy link
Copy Markdown
Contributor

I've got something that works, but should be reviewed, making a PR in a minute.

@andyleejordan andyleejordan mentioned this pull request Mar 7, 2014
@andyleejordan

Copy link
Copy Markdown
Contributor

Yeah, I procrastinated homework a bit :) Let me know what you think.

@deweysasser

Copy link
Copy Markdown
Author

Closing request in favor of #115 or #117

@deweysasser deweysasser closed this Mar 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants