Repository navigation
make runtime types internal - #557
Merged
Jamiras merged 5 commits intoOct 11, 2026
Merged
Conversation
scullymi
added a commit
to scullymi/rcheevos
that referenced
this pull request
Oct 11, 2026
The conflicts in rc_alloc.c and rc_richpresence.c come from RetroAchievements#557: the checks are now made in the new rc_alloc() and rc_alloc_scratch(). Since RetroAchievements#557 the scratch pointer array is allocated on first use, so the first RC_ALLOC of a preparse can fail too: the root objects are checked before they are parsed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There shouldn't be anything interacting with the raw data structures anymore (
rc_trigger_t,rc_lboard_t, etc). Clients should be interacting with anrc_runtime_t, or preferably anrc_client_t.rc_runtime_types.hhas been eliminated. All types previously defined in that file are now defined in individual header files in thesrc/runtimefolder. If a client absolutely has need to use these types, they just need to move to the alternate headers.Similarly,
rc_internal.hhas been broken up and the individual functions have been moved into their new type-specific internal header files.Also, as part of this PR, I've removed the
typedefs from forward-referenced types to eliminate pedantic compiler warnings without needing a bevy of#ifdefs. And I've cleaned up some of how theRC_ALLOCmacro works.