Skip to content

fix popups not appearing for local leaderboards #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jamiras merged 1 commit into from
Mar 29, 2026
Merged

fix popups not appearing for local leaderboards #1303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/data/models/LeaderboardModel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,11 @@ void LeaderboardModel::SyncStateToRuntime(AssetState nNewState) const
rc_mutex_unlock(&pClient->state.mutex);
}

void LeaderboardModel::SyncIDToRuntime() const
{
m_pLeaderboardInfo->public_.id = GetID();
}

void LeaderboardModel::SyncTitleToRuntime()
{
m_sTitleBuffer = ra::util::String::Narrow(GetName());
Expand Down Expand Up @@ -524,6 +529,7 @@ void LeaderboardModel::SyncToLocalLeaderboardInfo()
{
Expects(m_pLeaderboardInfo != nullptr);

SyncIDToRuntime();
SyncTitleToRuntime();
SyncDescriptionToRuntime();
SyncDefinitionToRuntime();
Expand Down
1 change: 1 addition & 0 deletions src/data/models/LeaderboardModel.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,7 @@ protected:
private:
void HandleStateChanged(AssetState nOldState, AssetState nNewState);

void SyncIDToRuntime() const;
void SyncTitleToRuntime();
void SyncDescriptionToRuntime();
void SyncStateToRuntime(AssetState nNewState) const;
Expand Down
Loading