feat(rfq): finalize durable provider settlements - #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SIGHASH_ALLprovider signatures, insert only the provider signature fields, and revalidate the canonical completed PSETSafety and recovery
The coordinator exact-matches the complete job and permanent provider allocations before invoking the signer. It maps targets by outpoint, verifies signatures against all committed prevouts and the provider chain identity, proves that no unrelated PSET field changed, then rechecks confidential proofs, balance, canonical encoding, size, and fee/weight facts before persistence.
Signing happens outside database locks. The signed-state transition is atomic and restart-safe: the first valid candidate persisted is authoritative, concurrent or stale-clock workers discard their local candidate and replay that exact winner, and persistence failures leave the exact committed job recoverable without exposing signed bytes.
The initial profile remains intentionally limited to one interactive RFQ provider plus finalized tree-less P2TR key-path inputs. Simplicity covenant inputs and multiple interactive RFQ providers remain future venue-verification work.
Validation
nix develop .#default --command just ci-checksdeadcat-rfq-providertests passedNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.