Repository navigation
Conversation
- Verify scripts run cargo fmt and rust-llm-tidy before every compile step. - Later steps validate the formatted and tidied files. - Bumped template version marker to 1.4.3 and updated the test order pin. - Added the v1.4.3 migration guide and registered it in the docs nav.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (7)
WalkthroughThe verification scripts now run ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verify scripts now run the file-altering steps before the build,
so later checks validate the files those steps leave behind.
Released as template v1.4.3.
Changes
.llm/verify.shand.llm/verify.ps1:cargo fmtandrust-llm-tidynow run first.already-modified files.
template-version.txttoreloaded-templates-rust:1.4.3and updated the version pin in the template tests.
precede the build, replacing the old "tidy after dry-run" assertion.
docs/migration/v1.4.3.md, registered inmkdocs.ymland the migration index.
Why
A passing verify run could still leave unverified edits.
Fmt and tidy ran after clippy and docs, and tidy even after
the publish dry-run.
A green run now leaves no unapplied or unchecked formatting.