Skip to content

Reorder verify steps to run fmt and tidy before build; release v1.4.3 - #33

Merged
Sewer56 merged 1 commit into
mainfrom
1.4.3
Sep 8, 2026
Merged

Sewer56 merged 1 commit into
mainfrom
1.4.3

Conversation

@Sewer56

@Sewer56 Sewer56 commented Sep 8, 2026

Copy link
Copy Markdown
Member

Summary

Verify scripts now run the file-altering steps before the build,
so later checks validate the files those steps leave behind.
Released as template v1.4.3.

Changes

  • Reordered .llm/verify.sh and .llm/verify.ps1:
    cargo fmt and rust-llm-tidy now run first.
  • Build, clippy, docs and the publish dry-run follow on the
    already-modified files.
  • Bumped template-version.txt to reloaded-templates-rust:1.4.3
    and updated the version pin in the template tests.
  • Test order assertions now check that the formatting and tidy steps
    precede the build, replacing the old "tidy after dry-run" assertion.
  • Added docs/migration/v1.4.3.md, registered in mkdocs.yml
    and the migration index.

Why

A passing verify run could still leave unverified edits.
Fmt and tidy ran after clippy and docs, and tidy even after
the publish dry-run.

A green run now leaves no unapplied or unchecked formatting.

- Verify scripts run cargo fmt and rust-llm-tidy before every compile step.
- Later steps validate the formatted and tidied files.
- Bumped template version marker to 1.4.3 and updated the test order pin.
- Added the v1.4.3 migration guide and registered it in the docs nav.
@Sewer56
Sewer56 merged commit 2ee0dbd into main Sep 8, 2026
3 of 4 checks passed
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: a7efc8bb-221d-41eb-a65c-c741c9d850a5

📥 Commits

Reviewing files that changed from the base of the PR and between 40750a0 and 3ae4c24.

📒 Files selected for processing (7)
  • .github/tests/test_template.py
  • docs/migration/about.md
  • docs/migration/v1.4.3.md
  • mkdocs.yml
  • templates/general/.github/template-version.txt
  • templates/general/src/.llm/verify.ps1
  • templates/general/src/.llm/verify.sh

Walkthrough

The verification scripts now run cargo fmt and rust-llm-tidy before the build and remaining checks. The publish dry-run now runs after the documentation build. Template tests validate this order for both scripts. The template version and migration documentation now use v1.4.3.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 1.4.3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Sewer56
Sewer56 deleted the 1.4.3 branch September 22, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant