Skip to content

fix: correct volumeRestorePolicy assignment in VirtualMachineRestore #2726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
acinko-rh wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −4
Open

fix: correct volumeRestorePolicy assignment in VirtualMachineRestore #2726

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7664e88
fix `volumeRestorePolicy` assignment in `VirtualMachineRestore` object
acinko-rh May 20, 2026
93bbff9
Merge branch 'main' into fix_volume_restore_policy_attribute
acinko-rh May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ocp_resources/virtual_machine_restore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def __init__(
teardown=True,
yaml_file=None,
delete_timeout=TIMEOUT_4MINUTES,
volume_name_policy=None,
volume_restore_policy=None,
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Comment thread
myakove marked this conversation as resolved.
**kwargs,
):
super().__init__(
Expand All @@ -37,7 +37,7 @@ def __init__(
)
self.vm_name = vm_name
self.snapshot_name = snapshot_name
self.volume_name_policy = volume_name_policy
self.volume_restore_policy = volume_restore_policy

def to_dict(self) -> None:
super().to_dict()
Expand All @@ -47,8 +47,8 @@ def to_dict(self) -> None:
spec["target"]["kind"] = VirtualMachine.kind
spec["target"]["name"] = self.vm_name
spec["virtualMachineSnapshotName"] = self.snapshot_name
if self.volume_name_policy:
spec["volumeNamePolicy"] = self.volume_name_policy
if self.volume_restore_policy:
spec["volumeRestorePolicy"] = self.volume_restore_policy

def wait_complete(self, status=True, timeout=TIMEOUT_4MINUTES):
"""
Expand Down