-
Notifications
You must be signed in to change notification settings - Fork 34
poc: CSS Modules using shadowrootadoptedstylesheets for the Lit SSR pipeline
#3012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zeroedin
wants to merge
23
commits into
main
Choose a base branch
from
poc/lit-ssr/css-modules
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 11 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
ef0774f
feat: deduplicate component CSS with shadowrootadpotedstylesheets
zeroedin 473dc06
fix: add shadowrootadoptedstylesheets polyfill, remove old dsd polyfill
zeroedin f969cf1
fix: inject @sheet marker for SSR CSS deduplication
zeroedin 5ce08bb
chore: lint
zeroedin cc3984e
chore: lint
zeroedin 862a909
chore: lint
zeroedin 4ed9da2
chore: lint
zeroedin ca64fe2
fix: correct accidental push of refactored style tags inlined with html
zeroedin 1e6e146
fix: improved polyfill with deepQuery and to skip non-custom elements
zeroedin 1a83921
Merge branch 'main' into poc/lit-ssr/css-modules
zeroedin 27effad
fix: attempt to prevent FOUC by applying adopted stylesheets via Muta…
zeroedin 84cd99c
docs: minify html/css template literals before SSR rendering
zeroedin 3e3f892
docs: ensure adopted stylesheets gets loaded for demos
zeroedin caf13c7
chore: correct eslint config
zeroedin d27f3bc
chore: lint
zeroedin 6dd5ca6
fix: html minifier source type
zeroedin 2bfd04f
Merge branch 'main' into poc/lit-ssr/css-modules
zeroedin f1231ff
fix: hydration errors, minify exports.
zeroedin 0ece0a1
fix: hydration errors, minify exports.
zeroedin 3764f61
docs: serve compiled+minified JS artifacts instead of transpiling TS …
zeroedin 653d945
chore: lint
zeroedin 6fca5f3
fix: css markers lost with typescript-transform-lit-css switching to …
zeroedin 77370c2
chore: lint
zeroedin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,3 @@ | ||
| // dsd polyfill needs to happen before hydration attempts | ||
| // lit-element-hydrate-support needs to be included before lit is loaded | ||
| import '/assets/javascript/dsd-polyfill.js'; | ||
| import '@lit-labs/ssr-client/lit-element-hydrate-support.js'; | ||
| import 'element-internals-polyfill'; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.