Skip to content

DXFED-3428: Research NPM scripts execution #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryanaltvater wants to merge 3 commits into
base: main
Choose a base branch
from
Open

DXFED-3428: Research NPM scripts execution #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ec6284
Added --ignore-scripts protection against postinstall lifecycle attacks
Apr 16, 2026
1ab6f4b
Removed unused dependencies
Apr 17, 2026
99420d5
Added link to the Repository Security Audit documentation for context
May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
- [Minimum requirements](#minimum-requirements)
- [Getting started](#getting-started)
- [Install NVM](#install-nvm)
- [Install Node](#install-node)
- [Install Gulp (CLI)](#install-gulp-cli)
- [Install dependencies](#install-dependencies)
- [Local development](#local-development)
- [Production](#production)
- [Minimum requirements](#minimum-requirements)
- [Getting started](#getting-started)
- [Install NVM](#install-nvm)
- [Install Node](#install-node)
- [Install Gulp (CLI)](#install-gulp-cli)
- [Install dependencies](#install-dependencies)
- [Local development](#local-development)
- [Production](#production)

# Minimum requirements

Expand Down Expand Up @@ -44,9 +44,11 @@ $ npm install -g gulp-cli
## Install dependencies

```
npm ci
npm run setup
```

> **Note:** `npm run setup` uses `--ignore-scripts` to protect against malicious postinstall lifecycle attacks, then selectively runs only approved scripts. See the [Repository Security Audit](https://redhat.atlassian.net/wiki/spaces/DUX/pages/402685263/Repository+Security+Audit) for context on this work.

## Local development

```
Expand Down
92 changes: 0 additions & 92 deletions gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,13 @@
const { dest, lastRun, series, src, watch } = require("gulp");
const autoprefixer = require("gulp-autoprefixer");
const browserSync = require("browser-sync").create();
// const cacheBust = require("gulp-cache-bust");
const cleanCss = require("gulp-clean-css");
const del = require("del");
// const directorySync = require("gulp-directory-sync");
const fileInclude = require("gulp-file-include");
const flatten = require("gulp-flatten");
const fs = require("fs");
const groupCssMediaQueries = require("gulp-group-css-media-queries");
const header = require("gulp-header");
// const imagemin = require("gulp-imagemin");
const notify = require("gulp-notify");
const path = require("path");
const pkg = require("./package.json");
Expand Down Expand Up @@ -169,94 +166,6 @@ function css() {
);
}

// ========================================================================== //
// IMAGES
// ========================================================================== //

// ========================================================================== //
// This task optimizes source image files, and places the files in the
// destination path.
// ========================================================================== //

// function images() {
// return src([pkg.paths.src.img + "**/*"], {
// since: lastRun(images),
// })
// .pipe(
// imagemin(
// [
// imagemin.gifsicle({
// interlaced: true,
// optimizationLevel: 3,
// }),
// imagemin.mozjpeg({
// progressive: true,
// }),
// imagemin.optipng({}),
// // imagemin.svgo({
// // plugins: [
// // // { addAttributesToSVGElement: true },
// // // { addClassesToSVGElement: true },
// // { cleanupAttrs: true },
// // { cleanupEnableBackground: true },
// // { cleanupIDs: true },
// // { cleanupListOfValues: true },
// // { cleanupNumericValues: true },
// // { collapseGroups: true },
// // { convertColors: true },
// // // { convertEllipseToCircle: true },
// // { convertPathData: true },
// // // { convertShapeToPath: true },
// // { convertStyleToAttrs: true },
// // { convertTransform: true },
// // { inlineStyles: true },
// // { mergePaths: true },
// // // { minifyStyles: true },
// // // { moveElemsAttrsToGroup: true },
// // // { moveGroupAttrsToElems: true },
// // // { prefixIDs: true },
// // // { removeAttributesBySelector: true },
// // // { removeAttrs: true },
// // { removeComments: true },
// // { removeDesc: true },
// // // { removeDimensions: true },
// // { removeDoctype: true },
// // { removeEditorsNSData: true },
// // // { removeElementsByAttr: true },
// // { removeEmptyAttrs: true },
// // { removeEmptyContainers: true },
// // { removeEmptyText: true },
// // { removeHiddenElems: true },
// // { removeMetadata: true },
// // { removeNonInheritableGroupAttrs: true },
// // // { removeOffCanvasPaths: true },
// // { removeRasterImages: true },
// // { removeScriptElement: true },
// // { removeStyleElement: true },
// // { removeTitle: true },
// // { removeUnknownsAndDefaults: true },
// // { removeUnusedNS: true },
// // { removeUselessDefs: true },
// // { removeUselessStrokeAndFill: true },
// // { removeViewBox: true },
// // // { removeXMLNS: true },
// // { removeXMLProcInst: true },
// // // { reusePaths: true },
// // { sortAttrs: true },
// // // { sortDefsChildren: true }
// // ]
// // })
// ],
// {
// verbose: true,
// }
// )
// )
// .pipe(dest([pkg.paths.src.img]))
// .pipe(directorySync(pkg.paths.src.img, pkg.paths.docs.img))
// .pipe(browserSync.stream());
// }

// ========================================================================== //
// JS
// ========================================================================== //
Expand Down Expand Up @@ -293,7 +202,6 @@ function js() {
includeParents: 0,
})
)
// .pipe(stripDebug())
.pipe(uglifyEs.default())
.pipe(
rename({
Expand Down
Loading