Use Stream.multi instead of forwardStream's inner Controller#601
Open
frankpepermans wants to merge 3 commits intomasterfrom
Open
Use Stream.multi instead of forwardStream's inner Controller#601frankpepermans wants to merge 3 commits intomasterfrom
frankpepermans wants to merge 3 commits intomasterfrom
Conversation
Member
Author
|
Some tests have been skipped, they all use Timers and were flaky by design. |
hoc081098
reviewed
Jun 15, 2021
| controller.onCancel = () { | ||
| final onCancelConnectedFuture = | ||
| _connectedSink.onCancel(_compositeController); | ||
| final onCancelSubscriptionFuture = _subscription?.cancel(); |
Collaborator
There was a problem hiding this comment.
Should we cancel subscription when canceling a MultiStreamController?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue where we rely on specific
createForwardingStream's, thus respecting the behavior of customStreamControllers, see: #587