Skip to content

test: fix all ruff lint errors in tests/test_observable/; remove from ruff exclude#778

Merged
dbrattli merged 4 commits intomasterfrom
repo-assist/pyright-ruff-cleanup-test-observable-scheduler-2026-04-21-6f569da2d139f64e
Apr 25, 2026
Merged

test: fix all ruff lint errors in tests/test_observable/; remove from ruff exclude#778
dbrattli merged 4 commits intomasterfrom
repo-assist/pyright-ruff-cleanup-test-observable-scheduler-2026-04-21-6f569da2d139f64e

Conversation

@dbrattli
Copy link
Copy Markdown
Collaborator

… ruff exclude

  • Fix E741: rename ambiguous variable names (l -> left/items/timers)
  • Fix E721: use isinstance() instead of type() comparison
  • Fix E501: wrap/noqa long assertion lines (marble test data)
  • Fix UP032/UP031/UP004/UP035 etc. via auto-fix (f-strings, useless inheritance, deprecated imports, annotations)
  • Remove tests/test_observable from ruff exclude list in pyproject.toml
  • All 153 ruff errors resolved; ruff --check passes cleanly

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 21, 2026

Coverage Status

coverage: 93.516% (+0.004%) from 93.512% — repo-assist/pyright-ruff-cleanup-test-observable-scheduler-2026-04-21-6f569da2d139f64e into master

@github-actions
Copy link
Copy Markdown
Contributor

Commit pushed: 2f7f369

Generated by Repo Assist

@github-actions
Copy link
Copy Markdown
Contributor

🤖 This is an automated update from Repo Assist.

I've pushed a formatting fix to resolve the code-quality CI failure — ruff format wanted blank lines added before inline function definitions and one redundant blank line removed in test_transformation_fluent.py, test_filtering_fluent.py, and test_starmap.py.

The remaining lint failure is due to the [Repo Assist] title prefix not being recognised by the semantic PR title check (amannn/action-semantic-pull-request). The title test: fix all ruff lint errors... is valid conventional commits — the [Repo Assist] prefix just needs to be stripped before merge (or the lint action could be configured to allow the prefix). Happy for you to rename the title to test: fix all ruff lint errors in tests/test_observable/; remove from ruff exclude if that's easiest.

Note

🔒 Integrity filter blocked 47 items

The following items were blocked because they don't meet the GitHub integrity level.

  • #749 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #748 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #742 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #736 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #711 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #700 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #698 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #634 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • using timeout with GroupedObservable leads to an index shift #225 list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • Sort hot observable between (slow) scan executions #237 list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • Observable interval appears to leak #259 list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • Example noteboks are out of date #265 list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • Proposal for a subscribe scheduler #309 list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • Convert async iterator to Obervable #422 list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • Weird interaction between group_by and to_iterable? #467 list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • Q: how to use scheduler with subject for concurrency? #528 list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • ... and 31 more items

To allow these resources, lower min-integrity in your GitHub frontmatter:

tools:
  github:
    min-integrity: approved  # merged | approved | unapproved | none

Generated by Repo Assist · ● 2.4M ·

@dbrattli dbrattli changed the title [Repo Assist] test: fix all ruff lint errors in tests/test_observable/; remove from ruff exclude test: fix all ruff lint errors in tests/test_observable/; remove from ruff exclude Apr 25, 2026
github-actions Bot and others added 3 commits April 25, 2026 10:24
… ruff exclude

- Fix E741: rename ambiguous variable names (l -> left/items/timers)
- Fix E721: use isinstance() instead of type() comparison
- Fix E501: wrap/noqa long assertion lines (marble test data)
- Fix UP032/UP031/UP004/UP035 etc. via auto-fix (f-strings, useless inheritance,
  deprecated imports, annotations)
- Remove tests/test_observable from ruff exclude list in pyproject.toml
- All 153 ruff errors resolved; ruff --check passes cleanly

Co-authored-by: Copilot <[email protected]>
- Drop unnecessary `# noqa: E501` from wrapped lines in test_starmap.py
  that already fit within 88 chars after wrapping.
- Restore docstrings in test_retry.py and test_method_chaining.py to
  more natural shapes, suppressing E501 on the whole docstring instead.

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
@dbrattli dbrattli force-pushed the repo-assist/pyright-ruff-cleanup-test-observable-scheduler-2026-04-21-6f569da2d139f64e branch from acd4d8b to 56f1103 Compare April 25, 2026 08:24
The test reads the wall clock twice with construction in between and
asserts the gap is under 5ms. Under pytest-xdist on a shared CI VM,
GC pauses or scheduler jitter routinely push that gap past 5ms
(observed 14ms in CI). 50ms still proves the scheduler is not
clearly broken without flaking on routine load.

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
@dbrattli dbrattli merged commit d78df7d into master Apr 25, 2026
43 checks passed
@dbrattli dbrattli deleted the repo-assist/pyright-ruff-cleanup-test-observable-scheduler-2026-04-21-6f569da2d139f64e branch April 25, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants