Conversation
5 tasks
- Add type annotations to closure container lists (list[T | None])
- Add type annotations to scheduler callback parameters
- Add assert narrowing before attribute access on nullable list items
- Fix on_error("ex") -> on_error(Exception("ex")) (real type bug)
- Remove unused _raise helper functions
- Remove SchedulerBase import where not needed
- Remove tests/test_subject/ from pyright exclude list in pyproject.toml
All 21 tests pass. Full pyright: 0 errors. Ruff: 0 errors.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…sistency Match the style already used in test_asyncsubject.py and test_subject.py so all four files use the same pattern before accessing subject[0]. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
dbrattli
force-pushed
the
repo-assist/pyright-cleanup-test-subject-scheduler-2026-04-17-e214b615e3b8b313
branch
from
3e31d41 to
53d42f4
Compare
|
coverage: 93.512% (+0.06%) from 93.448% — repo-assist/pyright-cleanup-test-subject-scheduler-2026-04-17-e214b615e3b8b313 into master |
dbrattli
deleted the
repo-assist/pyright-cleanup-test-subject-scheduler-2026-04-17-e214b615e3b8b313
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All 21 tests pass. Full pyright: 0 errors. Ruff: 0 errors.