Conversation
Fix 24 type errors detected when running pyright in standard (non-strict) mode on tests/test_scheduler/: - test_catchscheduler / test_virtualtimescheduler: add @classmethod to VirtualTimeScheduler.add overrides (base method is a classmethod) - test_currentthreadscheduler / test_immediatescheduler / test_timeoutscheduler: annotate [None]-initialised lists with the correct element type (list[SchedulerType | None]) to avoid __setitem__ type errors - test_eventloop/test_asyncioscheduler: widen callback parameter from AsyncIOScheduler to abc.SchedulerBase to match ScheduledAction protocol - test_eventloop/test_ioloopscheduler, test_twistedscheduler, test_mainloop/test_gtkscheduler: add # type: ignore[import-untyped] to optional-dependency imports (tornado, twisted, gi) - test_eventloopscheduler: annotate endtime as datetime | None; add assert is not None guard before arithmetic; fix schedule_periodic action to accept only a state argument (matching ScheduledPeriodicAction) - test_newthreadscheduler: fix action parameter and return types to match ScheduledPeriodicAction[int] (state: int | None) -> int | None - test_scheduleditem: align ScheduledItemTestScheduler override signatures with Scheduler base class (add default state=None, correct return types) pyproject.toml: update comment to reflect current status. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…6-04-17-762f95f7e6558b77
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix 24 type errors detected when running pyright in standard (non-strict) mode on tests/test_scheduler/:
pyproject.toml: update comment to reflect current status.