Skip to content

Ledger human friendly limit orders - #3002

Open
girazoki wants to merge 12 commits into
RaoFoundation:mainfrom
girazoki:girazoki-edger-human-friendly
Open

Ledger human friendly limit orders#3002
girazoki wants to merge 12 commits into
RaoFoundation:mainfrom
girazoki:girazoki-edger-human-friendly

Conversation

@girazoki

Copy link
Copy Markdown
Collaborator

Description

It provides an even more human friendly order verification to limit-orders pallet. Before the ledger users would need to sign the order-id hash, with this changes they can also sign an ASCII string that lets them be very aware of what they sign. This is purely additive with the existing features of the pallet.

The worst case scenario now is a signed order made this way, as it is the last being checked. benchmarks have been updated to reflect this. Also important note: orders are identified still by their order-id, so even if a user signs the same order with different mechanisms, replayability is still hold since all match to the same order-id

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run ./scripts/fix_rust.sh to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vercel

vercel Bot commented Jul 28, 2026

Copy link
Copy Markdown

@girazoki is attempting to deploy a commit to the RaoFoundation Team on Vercel.

A member of the Team first needs to authorize it.

@girazoki girazoki changed the title Girazoki edger human friendly Ledger human friendly limit orders Jul 28, 2026

@UnArbosSix UnArbosSix left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ledger hashes raw-signing payloads over 256 bytes before signing, but the runtime verifies the full payload. These messages exceed 256 bytes, so real Ledger signatures will fail. Verify the Blake2-256 hash for oversized payloads and add a Ledger test vector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants