Ledger human friendly limit orders - #3002
Open
girazoki wants to merge 12 commits into
Open
Conversation
|
@girazoki is attempting to deploy a commit to the RaoFoundation Team on Vercel. A member of the Team first needs to authorize it. |
UnArbosSix
requested changes
Jul 28, 2026
UnArbosSix
left a comment
Collaborator
There was a problem hiding this comment.
Ledger hashes raw-signing payloads over 256 bytes before signing, but the runtime verifies the full payload. These messages exceed 256 bytes, so real Ledger signatures will fail. Verify the Blake2-256 hash for oversized payloads and add a Ledger test vector.
UnArbosSix
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It provides an even more human friendly order verification to limit-orders pallet. Before the ledger users would need to sign the order-id hash, with this changes they can also sign an ASCII string that lets them be very aware of what they sign. This is purely additive with the existing features of the pallet.
The worst case scenario now is a signed order made this way, as it is the last being checked. benchmarks have been updated to reflect this. Also important note: orders are identified still by their order-id, so even if a user signs the same order with different mechanisms, replayability is still hold since all match to the same order-id
Type of Change
Checklist
./scripts/fix_rust.shto ensure my code is formatted and linted correctly