Skip to content

Fix root basket claim weight accounting - #2993

Open
UnArbosFive wants to merge 2 commits into
release-v438from
fix/claim-root-weight-accounting
Open

Fix root basket claim weight accounting#2993
UnArbosFive wants to merge 2 commits into
release-v438from
fix/claim-root-weight-accounting

Conversation

@UnArbosFive

Copy link
Copy Markdown
Contributor

Summary

  • bound root basket claims to 256 staking hotkeys and 256 raw basket-position rows before mutation
  • benchmark the full Root Reborn claim path with a single work parameter
  • use the canonical claim weight for both worst-case admission and post-dispatch refund
  • keep the claim within the production normal-extrinsic limit, including transaction extensions

Verification

  • 43 focused root-claim tests
  • parameterized claim_root benchmark test
  • production-runtime admission test including transaction extensions
  • diff and formatting audit

@vercel

vercel Bot commented Jul 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
subtensor Ready Ready Preview, Comment Jul 29, 2026 11:20am

Request Review

@UnArbosFive UnArbosFive added the run-benchmarks run benchmarks label Jul 27, 2026
@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

🛡️ AI Review — Skeptic (security review)

VERDICT: SAFE

HIGH contributor-risk signal from a 25-day-old account with no public repos, mitigated by admin permission and substantial merged repository work; no Gittensor association; release-v438 is an active integration branch.

Static analysis found the claim workload bounds, benchmark parameterization, declared admission weight, and post-dispatch refund internally consistent. The diff does not modify trusted AI-review or Copilot instruction files.

Findings

No findings.

Conclusion

No malicious behavior or security vulnerability was found. The change bounds both storage-scan dimensions before mutation and charges a conservative benchmark-derived weight.


🔍 AI Review — Auditor (domain review)

VERDICT: 👍

Gittensor association UNKNOWN; author is an established repository administrator with substantial recent contributions.

The implementation consistently bounds both hotkey and raw holding-row traversal, uses the benchmark-derived weight for admission and refund, and adds focused boundary and production-runtime admission coverage. The overlapping open PRs are broad integration/runtime changes rather than competing implementations. No auto-fixes were required.

Findings

No findings.

Conclusion

The accounting change is conservative, internally consistent, and adequately tested. No blocking domain issues were found.

@github-actions

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

unarbos added a commit that referenced this pull request Jul 28, 2026
Keep the fund-level claim_root surface (main's old-path fanout fix is
superseded by #2993), bump spec_version to 441 past main's v440, move the
Root Reborn release page to /releases/v441-upgrade so main's shipped v438
note survives, and regenerate the SDK docs and catalogs from the merged
registries.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-benchmarks run benchmarks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant