Anatoliylitv/bloat 16 use hip bfloat 16 as union#3113
Draft
anatoliylitv wants to merge 2 commits intorelease/2.9from
Draft
Anatoliylitv/bloat 16 use hip bfloat 16 as union#3113anatoliylitv wants to merge 2 commits intorelease/2.9from
anatoliylitv wants to merge 2 commits intorelease/2.9from
Conversation
- Introduced a union in the BFloat16 struct to accommodate __hip_bfloat16 alongside uint16_t for better compatibility with HIP. - Updated constructors and conversion operators to handle both __hip_bfloat16 and __nv_bfloat16 types based on the compilation environment. - Adjusted conditional compilation flags to streamline the code for ROCm and CUDA environments. This change enhances the flexibility of the BFloat16 type across different GPU architectures.
- Modified the conditional compilation directive for CUDA to remove ROCm-specific checks, ensuring compatibility with CUDA environments.
|
Jenkins build for bc14f20cdbe218145ccc87b62423e65e93c337ba commit finished as FAILURE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist