[Comgr] Add lit test for unbundling compressed amdgcnspirv bundles#2545
Open
lamb-j wants to merge 1 commit into
Open
[Comgr] Add lit test for unbundling compressed amdgcnspirv bundles#2545lamb-j wants to merge 1 commit into
lamb-j wants to merge 1 commit into
Conversation
Existing unbundle.hip covers --offload-compress for AMDGCN archs (gfx900, gfx1030) but no test exercises the compressed + amdgcnspirv combination. Add a spirv-tests/ test that: - builds a compressed bitcode bundle for amdgcnspirv, - sanity-checks the CCOB magic and the bundle entry ID, - extracts the amdgcnspirv entry through Comgr's unbundle action, - verifies the SPIR-V magic of the unbundled payload, and - translates it back to LLVM IR via spirv-translator and FileChecks the original device function is present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Existing
amd/comgr/test-lit/unbundle.hipcovers--offload-compressfor AMDGCN archs (gfx900, gfx1030) but no test exercises the compressed +amdgcnspirvcombination. This PR adds aspirv-tests/lit test that:amdgcnspirv,hip-spirv64-amd-amdhsa--amdgcnspirv),AMD_COMGR_ACTION_UNBUNDLE,0x07230203) of the unbundled payload, andspirv-translatorand FileChecks the original device function is present.Gated on
comgr-has-spirv-translator, matching the rest ofspirv-tests/.