Skip to content

Enable rccl and rccl-tests for more amdgpu targets #4935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ScottTodd merged 2 commits into from
Apr 30, 2026
+0 −36
Merged

Enable rccl and rccl-tests for more amdgpu targets #4935

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d50db2
Attempt to enable rccl and rccl-tests for all amdgpu targets
ScottTodd Apr 29, 2026
57cd6ba
Add back rccl and rccl-tests exclusions for 1103,1150,1152,1153
ScottTodd Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 0 additions & 36 deletions cmake/therock_amdgpu_targets.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,6 @@ therock_add_amdgpu_target(gfx900 "Vega 10 / MI25" FAMILY dgpu-all gfx900-dgpu
composable_kernel # https://github.com/ROCm/TheRock/issues/1245
rocWMMA # https://github.com/ROCm/TheRock/issues/1944
rocprofiler-compute # https://github.com/ROCm/TheRock/issues/2892
rccl # Disable on all but CDNA, see https://github.com/ROCm/TheRock/issues/2130
rccl-tests
)

# gfx90c
Expand All @@ -64,8 +62,6 @@ therock_add_amdgpu_target(gfx90c "AMD Renoir/Lucienne/Cezanne iGPU" FAMILY igpu-
composable_kernel # https://github.com/ROCm/TheRock/issues/1245
rocWMMA # https://github.com/ROCm/TheRock/issues/1944
rocprofiler-compute # https://github.com/ROCm/TheRock/issues/2892
rccl # Disable on all but CDNA, see https://github.com/ROCm/TheRock/issues/2130
rccl-tests
)

# gfx906 (separate family - different instruction support from gfx908/gfx90a)
Expand Down Expand Up @@ -104,8 +100,6 @@ therock_add_amdgpu_target(gfx1010 "AMD RX 5700" FAMILY dgpu-all gfx101X-all gfx1
composable_kernel # https://github.com/ROCm/TheRock/issues/1245
rocWMMA # https://github.com/ROCm/TheRock/issues/1944
rocprofiler-compute # https://github.com/ROCm/TheRock/issues/2892
rccl # Disable on all but CDNA, see https://github.com/ROCm/TheRock/issues/2130
rccl-tests
)
therock_add_amdgpu_target(gfx1011 "AMD Radeon Pro V520" FAMILY dgpu-all gfx101X-all gfx101X-dgpu
EXCLUDE_TARGET_PROJECTS
Expand All @@ -114,8 +108,6 @@ therock_add_amdgpu_target(gfx1011 "AMD Radeon Pro V520" FAMILY dgpu-all gfx101X-
composable_kernel # https://github.com/ROCm/TheRock/issues/1245
rocWMMA # https://github.com/ROCm/TheRock/issues/1944
rocprofiler-compute # https://github.com/ROCm/TheRock/issues/2892
rccl # Disable on all but CDNA, see https://github.com/ROCm/TheRock/issues/2130
rccl-tests
)

therock_add_amdgpu_target(gfx1012 "AMD RX 5500" FAMILY dgpu-all gfx101X-all gfx101X-dgpu
Expand All @@ -125,8 +117,6 @@ therock_add_amdgpu_target(gfx1012 "AMD RX 5500" FAMILY dgpu-all gfx101X-all gfx1
composable_kernel # https://github.com/ROCm/TheRock/issues/1245
rocWMMA # https://github.com/ROCm/TheRock/issues/1944
rocprofiler-compute # https://github.com/ROCm/TheRock/issues/2892
rccl # Disable on all but CDNA, see https://github.com/ROCm/TheRock/issues/2130
rccl-tests
)

# gfx103X family
Expand All @@ -136,26 +126,20 @@ therock_add_amdgpu_target(gfx1030 "AMD RX 6800 / XT" FAMILY dgpu-all gfx103X-all
hipSPARSELt # https://github.com/ROCm/TheRock/issues/2042
rocWMMA # https://github.com/ROCm/TheRock/issues/1944
rocprofiler-compute # https://github.com/ROCm/TheRock/issues/2892
rccl # Disable on all but CDNA, see https://github.com/ROCm/TheRock/issues/2130
rccl-tests
)
therock_add_amdgpu_target(gfx1031 "AMD RX 6700 / XT" FAMILY dgpu-all gfx103X-all gfx103X-dgpu
EXCLUDE_TARGET_PROJECTS
hipBLASLt # https://github.com/ROCm/TheRock/issues/1062
hipSPARSELt # https://github.com/ROCm/TheRock/issues/2042
rocWMMA # https://github.com/ROCm/TheRock/issues/1944
rocprofiler-compute # https://github.com/ROCm/TheRock/issues/2892
rccl # Disable on all but CDNA, see https://github.com/ROCm/TheRock/issues/2130
rccl-tests
)
therock_add_amdgpu_target(gfx1032 "AMD RX 6600" FAMILY dgpu-all gfx103X-all gfx103X-dgpu
EXCLUDE_TARGET_PROJECTS
hipBLASLt # https://github.com/ROCm/TheRock/issues/1062
hipSPARSELt # https://github.com/ROCm/TheRock/issues/2042
rocWMMA # https://github.com/ROCm/TheRock/issues/1944
rocprofiler-compute # https://github.com/ROCm/TheRock/issues/2892
rccl # Disable on all but CDNA, see https://github.com/ROCm/TheRock/issues/2130
rccl-tests
)
therock_add_amdgpu_target(gfx1033 "AMD Van Gogh iGPU" FAMILY igpu-all gfx103X-all gfx103X-igpu
EXCLUDE_TARGET_PROJECTS
Expand All @@ -164,58 +148,44 @@ therock_add_amdgpu_target(gfx1033 "AMD Van Gogh iGPU" FAMILY igpu-all gfx103X-al
rocWMMA # https://github.com/ROCm/TheRock/issues/1944
rocprofiler-compute # https://github.com/ROCm/TheRock/issues/2892
composable_kernel
rccl # Disable on all but CDNA, see https://github.com/ROCm/TheRock/issues/2130
rccl-tests
)
therock_add_amdgpu_target(gfx1034 "AMD RX 6500 XT" FAMILY dgpu-all gfx103X-all gfx103X-dgpu
EXCLUDE_TARGET_PROJECTS
hipBLASLt # https://github.com/ROCm/TheRock/issues/1062
hipSPARSELt # https://github.com/ROCm/TheRock/issues/2042
rocWMMA # https://github.com/ROCm/TheRock/issues/1944
rocprofiler-compute # https://github.com/ROCm/TheRock/issues/2892
rccl # Disable on all but CDNA, see https://github.com/ROCm/TheRock/issues/2130
rccl-tests
)
therock_add_amdgpu_target(gfx1035 "AMD Radeon 680M Laptop iGPU" FAMILY igpu-all gfx103X-all gfx103X-igpu
EXCLUDE_TARGET_PROJECTS
hipBLASLt # https://github.com/ROCm/TheRock/issues/1062
hipSPARSELt # https://github.com/ROCm/TheRock/issues/2042
rocWMMA # https://github.com/ROCm/TheRock/issues/1944
rocprofiler-compute # https://github.com/ROCm/TheRock/issues/2892
rccl # Disable on all but CDNA, see https://github.com/ROCm/TheRock/issues/2130
rccl-tests
)
therock_add_amdgpu_target(gfx1036 "AMD Raphael iGPU" FAMILY igpu-all gfx103X-all gfx103X-igpu
EXCLUDE_TARGET_PROJECTS
hipBLASLt # https://github.com/ROCm/TheRock/issues/1062
hipSPARSELt # https://github.com/ROCm/TheRock/issues/2042
rocWMMA # https://github.com/ROCm/TheRock/issues/1944
rocprofiler-compute # https://github.com/ROCm/TheRock/issues/2892
rccl # Disable on all but CDNA, see https://github.com/ROCm/TheRock/issues/2130
rccl-tests
)

# gfx110X family
therock_add_amdgpu_target(gfx1100 "AMD RX 7900 XTX" FAMILY dgpu-all gfx110X-all gfx110X-dgpu
EXCLUDE_TARGET_PROJECTS
hipSPARSELt # https://github.com/ROCm/TheRock/issues/2042
rocprofiler-compute # https://github.com/ROCm/TheRock/issues/2892
rccl # Disable on all but CDNA, see https://github.com/ROCm/TheRock/issues/2130
rccl-tests
)
therock_add_amdgpu_target(gfx1101 "AMD RX 7800 XT" FAMILY dgpu-all gfx110X-all gfx110X-dgpu
EXCLUDE_TARGET_PROJECTS
hipSPARSELt # https://github.com/ROCm/TheRock/issues/2042
rocprofiler-compute # https://github.com/ROCm/TheRock/issues/2892
rccl # Disable on all but CDNA, see https://github.com/ROCm/TheRock/issues/2130
rccl-tests
)
therock_add_amdgpu_target(gfx1102 "AMD RX 7700S/Framework Laptop 16" FAMILY dgpu-all gfx110X-all gfx110X-dgpu
EXCLUDE_TARGET_PROJECTS
hipSPARSELt # https://github.com/ROCm/TheRock/issues/2042
rocprofiler-compute # https://github.com/ROCm/TheRock/issues/2892
rccl # Disable on all but CDNA, see https://github.com/ROCm/TheRock/issues/2130
rccl-tests
)
therock_add_amdgpu_target(gfx1103 "AMD Radeon 780M Laptop iGPU" FAMILY igpu-all gfx110X-all gfx110X-igpu
EXCLUDE_TARGET_PROJECTS
Expand All @@ -236,8 +206,6 @@ therock_add_amdgpu_target(gfx1150 "AMD Strix Point iGPU" FAMILY igpu-all gfx115X
therock_add_amdgpu_target(gfx1151 "AMD Strix Halo iGPU" FAMILY igpu-all gfx115X-all gfx115X-igpu
EXCLUDE_TARGET_PROJECTS
hipSPARSELt # https://github.com/ROCm/TheRock/issues/2042
rccl # https://github.com/ROCm/TheRock/issues/150
rccl-tests
rocprofiler-compute # https://github.com/ROCm/TheRock/issues/2892
)
therock_add_amdgpu_target(gfx1152 "AMD Krackan 1 iGPU" FAMILY igpu-all gfx115X-all gfx115X-igpu
Expand All @@ -260,15 +228,11 @@ therock_add_amdgpu_target(gfx1200 "AMD RX 9060 / XT" FAMILY dgpu-all gfx120X-all
EXCLUDE_TARGET_PROJECTS
hipSPARSELt # https://github.com/ROCm/TheRock/issues/2042
rocprofiler-compute # https://github.com/ROCm/TheRock/issues/2892
rccl # Disable on all but CDNA, see https://github.com/ROCm/TheRock/issues/2130
rccl-tests
)
therock_add_amdgpu_target(gfx1201 "AMD RX 9070 / XT" FAMILY dgpu-all gfx120X-all
EXCLUDE_TARGET_PROJECTS
hipSPARSELt # https://github.com/ROCm/TheRock/issues/2042
rocprofiler-compute # https://github.com/ROCm/TheRock/issues/2892
rccl # Disable on all but CDNA, see https://github.com/ROCm/TheRock/issues/2130
rccl-tests
)

# Optional extension targets (used for out of tree target development).
Expand Down
Loading