Skip to content

Fix wrong hip compiler in subproject #4663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
macurtis-amd wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix wrong hip compiler in subproject #4663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cmake/therock_subproject.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1601,6 +1601,8 @@ function(_therock_cmake_subproject_setup_toolchain
list(APPEND _compiler_toolchain_addl_depends "${_hip_stamp_dir}/stage.stamp")
string(APPEND _toolchain_contents "string(APPEND CMAKE_CXX_FLAGS_INIT \" --hip-path=@_hip_dist_dir@\")\n")
string(APPEND _toolchain_contents "string(APPEND CMAKE_CXX_FLAGS_INIT \" --hip-device-lib-path=@_amd_llvm_device_lib_path@\")\n")
string(APPEND _toolchain_contents "set(CMAKE_HIP_COMPILER \"\${CMAKE_CXX_COMPILER}\")\n")
string(APPEND _toolchain_contents "set(CMAKE_HIP_FLAGS_INIT \"\${CMAKE_CXX_FLAGS_INIT}\")\n")
Comment on lines +1604 to +1605
Copy link
Copy Markdown
Member

@ScottTodd ScottTodd Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If CMAKE_HIP_COMPILER is not set, sub-projects will incorrectly find /opt/rocm*/lib/llvm/bin/clang++.

Including these options here in TheRock is fine, but I suspect we should also fix this somehow in the rocm projects themselves. See #3976 for a description of the broader problem. Discovering a (likely different/mismatched) tool from somewhere on the system other than the current install could be more risky than just raising an exception and requiring setting it explicitly (like what this PR does).

Do you know where this CMAKE_HIP_COMPILER is falling back to /opt/rocm/ if unset?

if(THEROCK_VERBOSE)
message(STATUS "HIP_DIR = ${_hip_dist_dir}")
endif()
Expand Down
Loading